Remove support for secrets managers #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
|
E2E template updates in |
stefannica
force-pushed
the
feature/remove-secrets-manages
branch
from
da674a1
to
55b3cae
Compare
|
E2E template updates in |
…zenml into feature/remove-secrets-manages
strickvl
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
This PR finally removes support for secrets managers as stack components. It also removes the secret schema registry, which is no longer useful and converts secrets schema classes into run-of-the-mill unpretentious Pydantic models.
Breaking change
The Secrets Manager stack component type has been deprecated some time ago in favor of the centralized Secrets Store. In this release, we're finally removing the Secrets Manager component type from the ZenML code base.
You can learn more about centralized secret management in our documentation: https://docs.zenml.io/user-guide/advanced-guide/secret-management .
IMPORTANT: Upon upgrading, all Secrets Manager stack components will be removed from the Stacks that still contain them and from the database. This also implies that access to any remaining secrets managed through Secrets Manager stack components will be lost. If you still have secrets configured and managed through Secrets Manager stack components, please consider migrating all your existing secrets to the centralized secrets store before upgrading by means of the
zenml secrets-manager secret migrateCLI command. Also see thezenml secret --helpcommand for more information.Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes