-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune of unused artifacts links via client #2192
Merged
avishniakov
merged 18 commits into
develop
from
feature/OSS-2718-prune-of-unused-artifacts-links-via-client
Jan 11, 2024
Merged
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
895d9fd
prune artifacts in client
avishniakov 69fb821
more tests
avishniakov f9ba6ca
Merge branch 'develop' into feature/OSS-2718-prune-of-unused-artifact…
avishniakov 1f604d4
remove branching
avishniakov ca11807
Update src/zenml/client.py
avishniakov 0b1c8ea
Update tests/integration/functional/test_client.py
avishniakov 133dd9f
Update tests/integration/functional/test_client.py
avishniakov 313f479
nits
avishniakov 6943853
Merge branch 'develop' into feature/OSS-2718-prune-of-unused-artifact…
strickvl 1ccdc47
Merge branch 'develop' into feature/OSS-2718-prune-of-unused-artifact…
strickvl b46b00d
Merge branch 'develop' into feature/OSS-2718-prune-of-unused-artifact…
avishniakov 65c5e25
resolve branching
avishniakov f0f2d37
Merge branch 'develop' into feature/OSS-2718-prune-of-unused-artifact…
avishniakov 3d03d59
`prune_artifact_versions` in SQLStore
avishniakov 5d1538f
Merge branch 'develop' into feature/OSS-2718-prune-of-unused-artifact…
avishniakov 8d3cff5
lint
avishniakov a5dbf15
wandb lint
avishniakov 64f93af
skip yamlfix on windows
avishniakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the PR where you implemented the "delete all model version artifacts", there is a performance hit with this type of loop that ends up calling the REST API multiple times. You should consider implementing this as a REST API endpoint and looping in the SQL zen store instead (perhaps even deleting entities en-masse through a single SQL query, if possible). This opens the possibility of using this functionality through the dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm half way through implementing this change, but stuck at the
verify_permissions_and_delete_entity
. It was rather clear what to check on single entry deletion, but here I prune Artifact, Artifact Version and Data at scale. Any thoughts? Shall I check for Admin permissions to do so?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a half-baked idea about how to get around this: maybe we need a new
prune
permission that you check globally at server level, as opposed to checking against every resource. But that requires more work, not only here, but probably also at Cloud API level.@schustmi what do you think ?