-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering artifacts with/without custom names #2226
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe recent update introduces a feature to filter artifacts by whether they have custom names. This is achieved through a new parameter in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- src/zenml/client.py (3 hunks)
- src/zenml/models/v2/core/artifact.py (1 hunks)
Additional comments: 2
src/zenml/models/v2/core/artifact.py (1)
- 139-140: The addition of the optional
has_custom_name
attribute to theArtifactFilter
class is consistent with the PR's objective to allow filtering artifacts by custom names.src/zenml/client.py (1)
- 2608-2614: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [2608-2639]
The
list_artifacts
method has been updated to include a new parameterhas_custom_name
which allows filtering artifacts based on whether they have custom names. This change is consistent with the PR objectives and the AI-generated summary of changes. The parameter is optional and defaults toNone
, which is a common pattern for optional filtering criteria in Python.The method's docstring has also been updated to reflect the new parameter, which is good for maintainability and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and easy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit