Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering artifacts with/without custom names #2226

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Jan 5, 2024

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Summary by CodeRabbit

  • New Features
    • Enhanced the artifact listing with an option to filter artifacts that have custom names.

Copy link
Contributor

coderabbitai bot commented Jan 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The recent update introduces a feature to filter artifacts by whether they have custom names. This is achieved through a new parameter in the list_artifacts function and a corresponding attribute in the ArtifactFilter class.

Changes

File Path Change Summary
src/zenml/client.py Added has_custom_name parameter to list_artifacts function to filter artifacts by custom names.
src/zenml/.../artifact.py Introduced has_custom_name attribute in ArtifactFilter class, defaulting to None.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@schustmi schustmi requested a review from strickvl January 5, 2024 10:32
@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Jan 5, 2024
@strickvl
Copy link
Contributor

strickvl commented Jan 5, 2024

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 487b4a9 and 5742120.
Files selected for processing (2)
  • src/zenml/client.py (3 hunks)
  • src/zenml/models/v2/core/artifact.py (1 hunks)
Additional comments: 2
src/zenml/models/v2/core/artifact.py (1)
  • 139-140: The addition of the optional has_custom_name attribute to the ArtifactFilter class is consistent with the PR's objective to allow filtering artifacts by custom names.
src/zenml/client.py (1)
  • 2608-2614: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [2608-2639]

The list_artifacts method has been updated to include a new parameter has_custom_name which allows filtering artifacts based on whether they have custom names. This change is consistent with the PR objectives and the AI-generated summary of changes. The parameter is optional and defaults to None, which is a common pattern for optional filtering criteria in Python.

The method's docstring has also been updated to reflect the new parameter, which is good for maintainability and clarity.

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy

Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schustmi schustmi requested a review from strickvl January 8, 2024 08:00
@strickvl strickvl merged commit a37246c into develop Jan 8, 2024
33 checks passed
@strickvl strickvl deleted the feature/artifact-filtering branch January 8, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants