Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCP Stack creation Wizard (CLI) #2826

Merged
merged 84 commits into from
Jul 11, 2024
Merged

Add GCP Stack creation Wizard (CLI) #2826

merged 84 commits into from
Jul 11, 2024

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Jul 4, 2024 •
edited
Loading

Describe changes

This PR adds the needed flavors/configs to serve GCP stacks in Stack creation wizard.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

avishniakov and others added 30 commits June 26, 2024 09:53
@avishniakov
initial codes
4af4307
@avishniakov
Merge branch 'develop' into feature/PRD-477-stack-wizard-cli
000a021
@avishniakov
prettify a bit
7461dec
@avishniakov
some aws pieces
d03804a
@avishniakov
add container registry
7399ba8
@avishniakov
refactor
0d5b646
@avishniakov
Merge branch 'develop' into feature/PRD-477-stack-wizard-cli
f6a3154
@bcdurak
new models
2cf6ad5
@bcdurak
new models
e60489e
@bcdurak
new constant
a293dc6
@bcdurak
converting it into a request
be18c34
@bcdurak
defining interface
37e664f
@bcdurak
rest zen store
092ea24
@bcdurak
checking permissions and scoping the request in the endpoint
524e4aa
@bcdurak
first version of the sql zen store
fa437fa
@avishniakov
rbac fixes
a8bb05c
@avishniakov
misc fixes
62635a8
@avishniakov
remove names duplicates
8c0b71d
@avishniakov
multiple service connectors support
3402bf8
@avishniakov
maybe working
8cd5c02
@avishniakov
likely to work
a0530b8
@bcdurak
some fixes and naming checks
4c2e37f
@bcdurak
linting
8b847ba
@bcdurak
analytics, name checks for stacks and cleanup
0801c59
@bcdurak
typo
63d9a35
@avishniakov
hamza's feedback
5e4235e
@avishniakov
minor docs update
e73590d
@bcdurak
various fixes from PR comments
b13c09e
@bcdurak
several more fixes
c97afe9
@bcdurak
reversing the order of the cleanup
81632cd
Base automatically changed from feature/PRD-477-stack-wizard-cli to develop July 5, 2024 13:03
stefannica
stefannica requested changes Jul 9, 2024
View reviewed changes
src/zenml/cli/stack.py Outdated Show resolved Hide resolved
src/zenml/cli/stack.py Outdated Show resolved Hide resolved
src/zenml/cli/stack.py Outdated Show resolved Hide resolved
src/zenml/cli/stack.py Outdated Show resolved Hide resolved
bcdurak
bcdurak approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@bcdurak bcdurak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comments above, the changes look good! Excited to add GCP into the mix.

stefannica
stefannica requested changes Jul 10, 2024
View reviewed changes
src/zenml/zen_stores/rest_zen_store.py Outdated Show resolved Hide resolved
src/zenml/cli/stack.py Outdated Show resolved Hide resolved
@avishniakov avishniakov merged commit e558c19 into develop Jul 11, 2024
7 of 53 checks passed
@avishniakov avishniakov deleted the feature/PRD-477-add-gcp branch July 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdurak bcdurak bcdurak approved these changes

@stefannica stefannica stefannica approved these changes

Assignees
No one assigned
Labels
run-slow-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avishniakov @stefannica @bcdurak @actions-user