Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated features: zenml deploy and zenml <stack-component> deploy #3089

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Oct 16, 2024

Describe changes

This PR removes the deprecated features that were used to deploy ZenML servers and ZenML stacks and stack components straight from the ZenML CLI. These are now replaced by one-click stack deployments and Terraform stack deployment modules. Mentions to the external mlstacks project are kept or even added as an alternative for now.

Docs are rendered here: https://zenml-io.gitbook.io/stefan-docs

Breaking Changes

This PR removes the following CLI commands and the functionality associated with them:

  • zenml deploy
  • zenml destroy
  • zenml stack recipe *
  • zenml stack deploy_mlstack
  • zenml stack destroy
  • zenml <stack-component> deploy
  • zenml <stack-component> destroy

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 16, 2024
@stefannica stefannica force-pushed the feature/remove-deprecated-features branch 2 times, most recently from 23f1388 to d89a427 Compare October 16, 2024 15:40
@stefannica stefannica force-pushed the feature/remove-deprecated-features branch from e3f294c to b571fcc Compare October 17, 2024 15:11
@htahir1 htahir1 requested a review from wjayesh October 18, 2024 07:18
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good we're finally doing it. Some care will have to be take how we frame it in the release notes, but otherwise aside from the one nit I found, LGTM.

---

# Custom secret stores

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to the same level as the secret-management.md file (that is, directly under deploying-zenml)? this section (manage-the-deployed-services) shouldn't exist anymore. in the toc.md, it is already positioned so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would then also have to update the path in the toc.md file to the parent directory. Thank you for fixing my oversight! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Contributor

@wjayesh wjayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go save for a small restructuring

stefannica and others added 2 commits October 18, 2024 13:10
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
@stefannica stefannica merged commit a4bd0b6 into develop Oct 18, 2024
73 of 76 checks passed
@stefannica stefannica deleted the feature/remove-deprecated-features branch October 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants