-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated features: zenml deploy
and zenml <stack-component> deploy
#3089
Conversation
23f1388
to
d89a427
Compare
e3f294c
to
b571fcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good we're finally doing it. Some care will have to be take how we frame it in the release notes, but otherwise aside from the one nit I found, LGTM.
--- | ||
|
||
# Custom secret stores | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to the same level as the secret-management.md file (that is, directly under deploying-zenml)? this section (manage-the-deployed-services
) shouldn't exist anymore. in the toc.md
, it is already positioned so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you would then also have to update the path in the toc.md
file to the parent directory. Thank you for fixing my oversight! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go save for a small restructuring
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Describe changes
This PR removes the deprecated features that were used to deploy ZenML servers and ZenML stacks and stack components straight from the ZenML CLI. These are now replaced by one-click stack deployments and Terraform stack deployment modules. Mentions to the external mlstacks project are kept or even added as an alternative for now.
Docs are rendered here: https://zenml-io.gitbook.io/stefan-docs
Breaking Changes
This PR removes the following CLI commands and the functionality associated with them:
zenml deploy
zenml destroy
zenml stack recipe *
zenml stack deploy_mlstack
zenml stack destroy
zenml <stack-component> deploy
zenml <stack-component> destroy
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes