Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrongly set Model.was_created_in_this_run attribute #3129

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

schustmi
Copy link
Contributor

Describe changes

Since we're not updating the Model in the pipeline/step configurations in the DB anymore, this attribute was incorrectly set all the time and not used in any useful way.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Oct 23, 2024
@schustmi schustmi requested a review from bcdurak October 23, 2024 11:59
@schustmi schustmi merged commit c99f585 into develop Oct 28, 2024
53 of 54 checks passed
@schustmi schustmi deleted the bugfix/remove-wronly-used-model-attribute branch October 28, 2024 08:27
schustmi added a commit that referenced this pull request Oct 28, 2024
* Remove wrongly set Model.was_created_in_this_run attribute

* Remove option from template yaml in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants