Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform best practices #3131

Merged
merged 23 commits into from
Nov 11, 2024
Merged

Terraform best practices #3131

merged 23 commits into from
Nov 11, 2024

Conversation

htahir1
Copy link
Contributor

@htahir1 htahir1 commented Oct 23, 2024

Describe changes

Preview: https://zenml-io.gitbook.io/hamza-test/how-to/infrastructure-deployment/infrastructure-as-code/terraform-stack-management and https://zenml-io.gitbook.io/hamza-test/how-to/infrastructure-deployment/infrastructure-as-code/best-practices

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@htahir1 htahir1 requested a review from stefannica October 23, 2024 13:19
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 23, 2024
Copy link
Contributor

coderabbitai bot commented Oct 26, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@htahir1 htahir1 requested a review from strickvl November 4, 2024 12:14
@htahir1 htahir1 marked this pull request as ready for review November 4, 2024 12:14
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 46.5%, saving 79.21 KB.

Filename Before After Improvement Visual comparison
docs/book/.gitbook/assets/terraform_providers_screenshot.png 170.19 KB 90.98 KB -46.5% View diff

369 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@strickvl strickvl added the documentation Improvements or additions to documentation label Nov 4, 2024
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! just some small nits

- Document all required configuration fields
- Consider component dependencies when organizing stacks
- Separate infrastructure and ZenML registration state
- Use workspaces for different environments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to workspace docs, or did you mean TF workspaces?

- Consider component dependencies when organizing stacks
- Separate infrastructure and ZenML registration state
- Use workspaces for different environments
- Keep registration state with the ML operations team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean?

htahir1 and others added 2 commits November 4, 2024 14:02
…ode/terraform-stack-management.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
@htahir1 htahir1 requested a review from strickvl November 4, 2024 14:12
…ode/terraform-stack-management.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
@htahir1 htahir1 requested a review from strickvl November 4, 2024 14:50
@stefannica stefannica merged commit fd58e57 into develop Nov 11, 2024
10 checks passed
@stefannica stefannica deleted the doc/terraform-iac-best-practices branch November 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants