-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform best practices #3131
Terraform best practices #3131
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 46.5%, saving 79.21 KB.
369 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! just some small nits
- Document all required configuration fields | ||
- Consider component dependencies when organizing stacks | ||
- Separate infrastructure and ZenML registration state | ||
- Use workspaces for different environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to workspace docs, or did you mean TF workspaces?
- Consider component dependencies when organizing stacks | ||
- Separate infrastructure and ZenML registration state | ||
- Use workspaces for different environments | ||
- Keep registration state with the ML operations team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean?
docs/book/how-to/infrastructure-deployment/infrastructure-as-code/terraform-stack-management.md
Outdated
Show resolved
Hide resolved
…ode/terraform-stack-management.md Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
docs/book/how-to/infrastructure-deployment/infrastructure-as-code/terraform-stack-management.md
Outdated
Show resolved
Hide resolved
…ode/terraform-stack-management.md Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
…o/zenml into doc/terraform-iac-best-practices
Describe changes
Preview: https://zenml-io.gitbook.io/hamza-test/how-to/infrastructure-deployment/infrastructure-as-code/terraform-stack-management and https://zenml-io.gitbook.io/hamza-test/how-to/infrastructure-deployment/infrastructure-as-code/best-practices
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes