Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change formats props make editor disappear #836

Open
2 of 3 tasks
aliakbarazizi opened this issue Sep 14, 2022 · 17 comments
Open
2 of 3 tasks

Change formats props make editor disappear #836

aliakbarazizi opened this issue Sep 14, 2022 · 17 comments

Comments

@aliakbarazizi
Copy link

aliakbarazizi commented Sep 14, 2022

Ticket due diligence

  • I have verified that the issue persists under ReactQuill v2.0.0-beta.2
  • I can't use the beta version for other reasons

ReactQuill version

  • v2.0.0

FAQ

Is this a bug in Quill or ReactQuill? ReactQuill

When I try to change formats on some events it make editor to disappear

demo: https://codesandbox.io/s/ancient-lake-nss6wi?file=/src/App.js

@aliakbarazizi
Copy link
Author

This issue only exist in v2.0.0 and in v1 there is no problem

@duhdugg
Copy link

duhdugg commented Sep 21, 2022

I am getting the same when changing the theme prop.

Demo: https://codesandbox.io/s/elated-hodgkin-39380o?file=/src/App.js

duhdugg added a commit to duhdugg/react-quill that referenced this issue Sep 22, 2022
* This fixes an issue (zenoamaro#836) where the editor disappears on certain prop
  changes
@duhdugg
Copy link

duhdugg commented Sep 22, 2022

PR #838 submitted

@cmrd-senya
Copy link

Is it the same as #833 ?

@duhdugg
Copy link

duhdugg commented Oct 28, 2022

Is it the same as #833 ?

I think so. My PR should fix both.

@esetnik
Copy link

esetnik commented Nov 14, 2022

@zenoamaro can we get #833 merged and released please? v2.0.0 doesn't work at all with react 18.

@jeffdrumgod
Copy link

Same problem here, and successfully fixed with the changes of @duhdugg. Tks man!
@zenoamaro @aliakbarazizi can help us accepting PR #838 plz <3 ?

@bravodavid56
Copy link

bump on this
@zenoamaro

@jordanmiguel
Copy link

Bumping @zenoamaro

@ido-journey
Copy link

bumping @zenoamaro

1 similar comment
@supaset21
Copy link

bumping @zenoamaro

@abrarhayat
Copy link

Bumping @zenoamaro

@ondravondra
Copy link

ondravondra commented Mar 26, 2024

is this library even supported anymore ? this caused critical error on our production!!! how is this not fixed for almost 2 years?

@esetnik
Copy link

esetnik commented Mar 26, 2024

@ondravondra Are you willing to maintain a fork? I think the project has been abandoned.

@abrarhayat
Copy link

@esetnik I am interested in maintaining a fork.

@esetnik
Copy link

esetnik commented Apr 3, 2024

@abrarhayat ok great, want to setup a repo and get something published on NPM?

@abrarhayat
Copy link

Here is my fork:

https://github.com/abrarhayat/react-quill-abrarhayat

And here it is released:

https://www.npmjs.com/package/react-quill-abrarhayat

This release has the fix from @duhdugg

Innders added a commit to Innders/react-quill-ayon that referenced this issue May 2, 2024
This fixes an issue (zenoamaro#836) where the editor disappears on certain prop changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests