fix(2.x): allow sequence with associative arrays (#595)

zenstruck · May 8, 2024 · 0479ddf · 0479ddf
1 parent d5d83dd
commit 0479ddf
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/FactoryCollection.php b/src/FactoryCollection.php
@@ -80,8 +80,9 @@ public function all(): array
     {
         $factories = [];
 
-        foreach (($this->items)() as $i => $attributes) {
-            $factories[] = $this->factory->with($attributes)->with(['__index' => $i + 1]);
+        $i = 1;
+        foreach (($this->items)() as $attributes) {
+            $factories[] = $this->factory->with($attributes)->with(['__index' => $i++]);
         }
 
         return $factories;

diff --git a/tests/Unit/ObjectFactoryTest.php b/tests/Unit/ObjectFactoryTest.php
@@ -370,7 +370,7 @@ public static function sequenceDataProvider(): iterable
             ],
         ];
 
-        yield 'sequence as iterable which returns array' => [
+        yield 'sequence as callable which returns array' => [
             static fn() => array_map(
                 static fn(int $i) => ['prop1' => "foo{$i}", 'prop2' => "bar{$i}"],
                 range(1, 2)
@@ -389,6 +389,29 @@ static function () {
         ];
     }
 
+    /**
+     * @test
+     */
+    public function can_use_sequence_with_associative_array(): void
+    {
+        self::assertEquals(
+            [
+                new Object1('foo1', 'bar1'),
+                new Object1('foo2', 'bar2'),
+            ],
+            Object1Factory::createSequence([
+                'object 1' => [
+                    'prop1' => 'foo1',
+                    'prop2' => 'bar1',
+                ],
+                'object 2' => [
+                    'prop1' => 'foo2',
+                    'prop2' => 'bar2',
+                ],
+            ]),
+        );
+    }
+
     /**
      * @test
      */