fix: use orm limit length in factory (#294)

zenstruck · Nov 15, 2022 · cd1e394 · cd1e394
1 parent b1d7ce3
commit cd1e394
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 11 deletions.
diff --git a/src/Bundle/Maker/MakeFactory.php b/src/Bundle/Maker/MakeFactory.php
@@ -26,7 +26,7 @@ final class MakeFactory extends AbstractMaker
 {
     private const DEFAULTS = [
         'ARRAY' => '[],',
-        'ASCII_STRING' => 'self::faker()->text(),',
+        'ASCII_STRING' => 'self::faker()->text({length}),',
         'BIGINT' => 'self::faker()->randomNumber(),',
         'BLOB' => 'self::faker()->text(),',
         'BOOLEAN' => 'self::faker()->boolean(),',
@@ -44,10 +44,10 @@ final class MakeFactory extends AbstractMaker
         'JSON_ARRAY' => '[],',
         'SIMPLE_ARRAY' => '[],',
         'SMALLINT' => 'self::faker()->numberBetween(1, 32767),',
-        'STRING' => 'self::faker()->text(),',
-        'TEXT' => 'self::faker()->text(),',
-        'TIME_MUTABLE' => 'self::faker()->dateTime(),',
-        'TIME_IMMUTABLE' => '\DateTimeImmutable::createFromMutable(self::faker()->dateTime()),',
+        'STRING' => 'self::faker()->text({length}),',
+        'TEXT' => 'self::faker()->text({length}),',
+        'TIME_MUTABLE' => 'self::faker()->datetime(),',
+        'TIME_IMMUTABLE' => '\DateTimeImmutable::createFromMutable(self::faker()->datetime()),',
     ];
 
     /** @var string[] */
@@ -232,12 +232,13 @@ private function defaultPropertiesFor(string $class, bool $allFields): iterable
 
             $type = \mb_strtoupper($property['type']);
             $value = "null, // TODO add {$type} {$dbType} type manually";
+            $length = $property['length'] ?? '';
 
             if (\array_key_exists($type, self::DEFAULTS)) {
                 $value = self::DEFAULTS[$type];
             }
 
-            yield $property['fieldName'] => $value;
+            yield $property['fieldName'] => \str_replace('{length}', (string) $length, $value);
         }
     }
 

diff --git a/tests/Fixtures/Maker/expected/can-create-factory-in-test-dir-interactively.php b/tests/Fixtures/Maker/expected/can-create-factory-in-test-dir-interactively.php
@@ -37,7 +37,7 @@ protected function getDefaults(): array
     {
         return [
             // TODO add your default values here (https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories)
-            'name' => self::faker()->text(),
+            'name' => self::faker()->text(255),
         ];
     }
 

diff --git a/tests/Fixtures/Maker/expected/can-create-factory-in-test-dir.php b/tests/Fixtures/Maker/expected/can-create-factory-in-test-dir.php
@@ -37,7 +37,7 @@ protected function getDefaults(): array
     {
         return [
             // TODO add your default values here (https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories)
-            'name' => self::faker()->text(),
+            'name' => self::faker()->text(255),
         ];
     }
 

diff --git a/tests/Fixtures/Maker/expected/can-create-factory-interactively.php b/tests/Fixtures/Maker/expected/can-create-factory-interactively.php
@@ -37,7 +37,7 @@ protected function getDefaults(): array
     {
         return [
             // TODO add your default values here (https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories)
-            'name' => self::faker()->text(),
+            'name' => self::faker()->text(255),
         ];
     }
 

diff --git a/tests/Fixtures/Maker/expected/can-create-factory-with-phpstan-annotations.php b/tests/Fixtures/Maker/expected/can-create-factory-with-phpstan-annotations.php
@@ -52,7 +52,7 @@ protected function getDefaults(): array
     {
         return [
             // TODO add your default values here (https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories)
-            'name' => self::faker()->text(),
+            'name' => self::faker()->text(255),
         ];
     }
 

diff --git a/tests/Fixtures/Maker/expected/can-create-factory.php b/tests/Fixtures/Maker/expected/can-create-factory.php
@@ -37,7 +37,7 @@ protected function getDefaults(): array
     {
         return [
             // TODO add your default values here (https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories)
-            'name' => self::faker()->text(),
+            'name' => self::faker()->text(255),
         ];
     }