Adds an 'All' option to factory generation that creates all uncreated factories. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @abeal-hottomali! Yeah, the test suite is a bit of a bear. I'll work out the tests before merging. |
|
Cheers, appreciated!
…--
Aron Beal
Developer Team Lead
***@***.***
Hot Tomali Communications
1441 East Pender Street
Vancouver BC V5L 1V7
P 604.893.8347
P 604.893.8346
www.hottomali.com
On Feb 3, 2022, 5:23 AM -0800, Kevin Bond ***@***.***>, wrote:
Thanks for working on this @abeal-hottomali! Yeah, the test suite is a bit of a bear. I'll work out the tests before merging.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thanks @abeal-hottomali! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would address #15
Tests still TBD. What's the default testing mechanism?
**Edit: Looking at the existing tests, I'm a bit unsure how to proceed. I found
\Zenstruck\Foundry\Tests\Unit\Bundle\DependencyInjection\ZenstruckFoundryExtensionTest, but I'm not seeing where you tested that existing entities showed up as options, and that maker output was actually generated? If you don't consider that needing testing, let me know - I think this works, otherwise.