Make Story::get() static (implies Story::load()->get())

[kbond]

Instead of calling MyStory::load()->get('some-state'), can call MyStory::get('some-state'). This deprecates calling ->get() instance method.

[kbond]

@wouterj, what do you think about this? There is now no longer a way to access story state items without loading the story. Do you think this is a problem?

[wouterj]

@wouterj, what do you think about this? There is now no longer a way to access story state items without loading the story. Do you think this is a problem?

I would ask this question the other way (and I'm sure you did already and know the answer, but I'm missing some context): What does this change solve?

Having a $story->get('countries') method with proper PHP declaration (and thus SA and auto completion) seems better than $story->countries() to me personally.

[kbond]

What does this change solve?

This PR is purely a quality of life improvement:

- MyStory::load()->get('countries');
+ MyStory::get('countries');

Having a $story->get('countries') method with proper PHP declaration (and thus SA and auto completion) seems better than $story->countries() to me personally.

This PR doesn't change this ability. The idea is you'd add @method annotations to your story to help with autocompletion.