Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename service ids #363

Merged
merged 1 commit into from
Nov 24, 2022
Merged

chore: rename service ids #363

merged 1 commit into from
Nov 24, 2022

Conversation

kbond
Copy link
Member

@kbond kbond commented Nov 24, 2022 •
edited
Loading

Fixes #360

@kbond kbond merged commit 730c0d9 into zenstruck:1.x Nov 24, 2022
@kbond kbond deleted the service-id branch November 24, 2022 18:33
@wouterj
Copy link
Contributor

wouterj commented Nov 24, 2022

Note that technically speaking, this is a BC break. You can add an alias from FQCN to the new service ID and deprecate that alias to avoid the break.

@kbond
Copy link
Member Author

kbond commented Nov 24, 2022

I thought of this but since all these classes are marked @internal I figured we were ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename service IDs
2 participants
@kbond @wouterj