Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: allow symfony/string 5.4 #369

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Nov 29, 2022

Currently it's not possible to install the latest version of foundry with Symfony 5.4 if you're using Symfony Flex & the extra.symfony.require composer option:

symfony new foundry-test --version=5.4 --webapp
cd foundry-test/
composer require --dev foundry

Result:

Using version ^1.24 for zenstruck/foundry
./composer.json has been updated
Running composer update zenstruck/foundry
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires zenstruck/foundry ^1.24 -> satisfiable by zenstruck/foundry[v1.24.0].
    - zenstruck/foundry v1.24.0 requires symfony/string ^6.0 -> found symfony/string[v6.0.0, ..., v6.1.7] but it conflicts with your root composer.json require (5.4.*).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require zenstruck/foundry:*" to figure out if any version is installable, or "composer require zenstruck/foundry:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Since I can't find any technical reason not to allow symfony/string version 5.4.* I'd suggest adding it to composer.json to fix this issue.

@nikophil
Copy link
Member

Hi @HypeMC

you' re absolutely right.

I'll merge as soon as the CI is green.

thanks.

@nikophil nikophil changed the title Allow symfony/string 5.4 dependencies: allow symfony/string 5.4 Nov 29, 2022
@nikophil nikophil merged commit 6588804 into zenstruck:1.x Nov 29, 2022
@HypeMC HypeMC deleted the allow-string-5.4 branch November 29, 2022 17:57
@kbond
Copy link
Member

kbond commented Nov 29, 2022

Thanks @HypeMC, just released a patch release that includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants