Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: remove faker()/defaultObjectInstantiator() from FactoryManager #498

Merged
merged 1 commit into from
Aug 29, 2023
Merged

minor: remove faker()/defaultObjectInstantiator() from FactoryManager #498

merged 1 commit into from
Aug 29, 2023

Conversation

kbond
Copy link
Member

@kbond kbond commented Aug 28, 2023

No description provided.

@kbond kbond marked this pull request as draft August 28, 2023 20:37
@kbond
Copy link
Member Author

kbond commented Aug 28, 2023 •
edited
Loading

I'll fix this up tomorrow.

@kbond kbond marked this pull request as ready for review August 29, 2023 12:43
@kbond
Copy link
Member Author

kbond commented Aug 29, 2023

@nikophil, any idea why the phpstan is failing on that line now?

@nikophil
Copy link
Member

hum I don't know 🤔
I'll have a closer look later if you don't find

@kbond
Copy link
Member Author

kbond commented Aug 29, 2023

Ignoring for now - it's clearly invalid. I think, previously, the iterable $factories property wasn't type-hinted so phpstan didn't complain.

@kbond kbond merged commit 37fb907 into zenstruck:feat/split-factories Aug 29, 2023
26 checks passed
@kbond kbond deleted the use-configuration branch August 29, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbond @nikophil