Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test to check if big int datatype messes with the proxy #764

Closed
wants to merge 2 commits into from

Conversation

KDederichs
Copy link
Contributor

@KDederichs KDederichs commented Dec 17, 2024

related to #710

@KDederichs KDederichs force-pushed the bug/756 branch 3 times, most recently from 13a82b3 to 5bf0a81 Compare December 17, 2024 18:58
@nikophil
Copy link
Member

Aaaand tests are passing 😅

(The failure comes from a namespace problem)

@KDederichs
Copy link
Contributor Author

yeah I'm trying to figure out if it's a Postgres thing... but something's wrong with those, can't figure out what atm :D

@KDederichs
Copy link
Contributor Author

There you go, it only happens when you use an UUID as primary key... figures (no clue how to fix the other tests, not sure what's wrong with them)

Copy link
Member

@nikophil nikophil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very strange, that it only fails when uuid is involved 🤷

tests/Fixture/Factories/BigIntProxyFactory.php Outdated Show resolved Hide resolved
@nikophil
Copy link
Member

ok then, it has nothing do to with uuid. If you do this change:

- self::assertEquals($entity->getId(), $entity->getId());
+ self::assertEquals($entity->getBigIntVal(), $entity->getBigIntVal());

it will fail regardeless you use uuid or not.

And it receives an int from the database, so it thinks the original data is an int... this looks like a little quirk in the ORM.

I'm afraid there is nothing we can do in Foundry. I'll close this PR, and keep the issue for the record.

@nikophil nikophil closed this Dec 17, 2024
@KDederichs
Copy link
Contributor Author

Yeah I suspect it might be a doctrine issue, cause it's supposed to load that as string according to them, I guess I'll bring it up there and see what they say about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants