-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test to check if big int datatype messes with the proxy #764
Conversation
13a82b3
to
5bf0a81
Compare
Aaaand tests are passing 😅 (The failure comes from a namespace problem) |
yeah I'm trying to figure out if it's a Postgres thing... but something's wrong with those, can't figure out what atm :D |
There you go, it only happens when you use an UUID as primary key... figures (no clue how to fix the other tests, not sure what's wrong with them) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very strange, that it only fails when uuid is involved 🤷
ok then, it has nothing do to with uuid. If you do this change: - self::assertEquals($entity->getId(), $entity->getId());
+ self::assertEquals($entity->getBigIntVal(), $entity->getBigIntVal()); it will fail regardeless you use uuid or not. And it receives an int from the database, so it thinks the original data is an int... this looks like a little quirk in the ORM. I'm afraid there is nothing we can do in Foundry. I'll close this PR, and keep the issue for the record. |
Yeah I suspect it might be a doctrine issue, cause it's supposed to load that as string according to them, I guess I'll bring it up there and see what they say about it. |
related to #710