Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2387 - Fix Seg fault in mixed return type #2388

Merged
merged 3 commits into from
Sep 17, 2022
Merged

#2387 - Fix Seg fault in mixed return type #2388

merged 3 commits into from
Sep 17, 2022

Conversation

Jeckerson
Copy link
Member

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson self-assigned this Sep 16, 2022
@Jeckerson Jeckerson linked an issue Sep 16, 2022 that may be closed by this pull request
Fix seg fault with mixed return type and PHP 7.4 #2387
Closed
@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #2388 (40fdde4) into development (717b0ce) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             development   #2388   +/-   ##
=============================================
  Coverage           7.13%   7.13%           
  Complexity          8633    8633           
=============================================
  Files                343     343           
  Lines              21949   21947    -2     
=============================================
  Hits                1567    1567           
+ Misses             20382   20380    -2

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jeckerson Jeckerson merged commit c779467 into development Sep 17, 2022
@Jeckerson Jeckerson deleted the #2387-mixed-seg-fault branch September 17, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@AlexNDRmac AlexNDRmac Awaiting requested review from AlexNDRmac

Assignees

@Jeckerson Jeckerson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix seg fault with mixed return type and PHP 7.4
2 participants
@Jeckerson @niden