Get the class using its name, not just its namespace name

[27pchrisl]

Hi!

• Type: bug fix
• Link to issue: *_ce undeclared (first use in this function) #2277 (FYI @andrewdalpino)

In raising this pull request, I confirm the following:

• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR (not yet, but I can do if this is a correct fix)
• I updated the CHANGELOG

Small description of change: I made this change while diagnosing why https://github.com/RubixML/Tensor could not be compiled against PHP 8.3, it was encountering the same issue as described in #2277.

The compile errors were, for example:
/Users/chrisl/Code/Tensor/ext/tensor/vector.zep.c:3715:30: error: use of undeclared identifier '_tensor_ce'

This was because for an example class Tensor\Vector the compiler was generating the identifier _tensor_ce instead of tensor_vector_ce.

I tracked this down to

zephir/src/Class/Entry.php

Line 111 in c68f9cd

$classNamespace = explode(self::NAMESPACE_SEPARATOR, $reflection->getNamespaceName());

in the area where the code has different techniques for discovering the class name and namespace.

If I force the code to use the simpler technique by making the conditional at

zephir/src/Class/Entry.php

Line 93 in c68f9cd

if (class_exists($this->classname) || interface_exists($this->classname)) {

false, it gets $classNamespace and $className correctly for the code that follows the if statement. It appeared that $classNamespace should be the FQDN, not just the namespace.

I was not sure whether this was the correct fix for this issue, so I welcome any feedback.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud