nrfx: hal: nrf_comp: patch main_mode and speed_mode set #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kl-cruz
reviewed
Aug 20, 2024
nrfx/hal/nrf_comp.h
Outdated
| @@ -481,12 +481,14 @@ NRF_STATIC_INLINE void nrf_comp_th_set(NRF_COMP_Type * p_reg, nrf_comp_th_t thre | |||
| NRF_STATIC_INLINE void nrf_comp_main_mode_set(NRF_COMP_Type * p_reg, | |||
| nrf_comp_main_mode_t main_mode) | |||
| { | |||
| p_reg->MODE &= ~(COMP_MODE_MAIN_Msk); | |||
There was a problem hiding this comment.
I recommend to make it similar to for example spim:
https://github.com/zephyrproject-rtos/hal_nordic/blob/master/nrfx/hal/nrf_spim.h#L1524
or
https://github.com/zephyrproject-rtos/hal_nordic/blob/master/nrfx/hal/nrf_glitchdet.h#L103
p_reg->MODE = (p_reg->MODE & ~(COMP_MODE_MAIN_Msk)) | (main_mode << COMP_MODE_MAIN_Pos);
The functions for setting the main and speed modes don't clear their fields before setting the desired value. This results in not being able to set the main mode to single-ended (0) after having set the mode to differential (1), similarly, the speed mode can not be set to low (0) after being set to medium (1) or high (2), and it can be set to the reserved value 3. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
force-pushed
the
patch-nrf-comp-mode-set
branch
from
8c43440
to
2e8e2d0
Compare
|
ping @kl-cruz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions for setting the main and speed modes don't clear their fields before setting the desired value. This results in not being able to set the main mode to single-ended (0) after having set the mode to differential (1), similarly, the speed mode can not be set to low (0) after being set to medium (1) or high (2), and it can be set to the reserved value 3.