Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAM devices are missing the DMA API get_status() implementation #62003

Closed
tswaehn opened this issue Aug 29, 2023 · 4 comments · Fixed by #62002
Closed

SAM devices are missing the DMA API get_status() implementation #62003

tswaehn opened this issue Aug 29, 2023 · 4 comments · Fixed by #62002
Labels
area: DMA Direct Memory Access Enhancement Changes/Updates/Additions to existing features platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Comments

@tswaehn
Copy link
Contributor

tswaehn commented Aug 29, 2023

Is your enhancement proposal related to a problem? Please describe.
The DMA API allows to read the current status of a DMA channel. However this is not yet implemented for SAM XDMAC.

Describe the solution you'd like
All required registers are defined. Would be a small fix to add this functionality.

Describe alternatives you've considered
I could patch the zephyr after downloading via git and use my patched version.

Additional context
I will create a fork and merge request with the required changes.
@tswaehn tswaehn added the Enhancement Changes/Updates/Additions to existing features label Aug 29, 2023
@tswaehn tswaehn mentioned this issue Aug 29, 2023
Merged
@henrikbrixandersen henrikbrixandersen added area: DMA Direct Memory Access platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Aug 29, 2023
tswaehn pushed a commit to tswaehn/zephyr that referenced this issue Aug 29, 2023
dma_sam_xdmac - implemented dma device get_status()
3ea0faf 
this fixes zephyrproject-rtos#62003
tswaehn pushed a commit to tswaehn/zephyr that referenced this issue Aug 29, 2023
dma_sam_xdmac - implemented dma device get_status()
fd3575e 
Fixes zephyrproject-rtos#62003
@tswaehn
Copy link
Contributor Author

tswaehn commented Aug 29, 2023

pull request is ready. whats next?

tswaehn pushed a commit to tswaehn/zephyr that referenced this issue Aug 29, 2023
dma_sam_xdmac - implemented dma device get_status()
87accd8 
Fixes zephyrproject-rtos#62003

dma_sam_xdmac - implemented dma device get_status()
Fixes zephyrproject-rtos#62003
@tswaehn
Copy link
Contributor Author

tswaehn commented Aug 30, 2023

@henrikbrixandersen just wondering how to find a reviewer for the PR ?

@henrikbrixandersen
Copy link
Member

@henrikbrixandersen just wondering how to find a reviewer for the PR ?

A few reviewers are assigned now.

tswaehn added a commit to tswaehn/zephyr that referenced this issue Aug 30, 2023
@tswaehn
dma_sam_xdmac - implemented dma device get_status() - Fixes zephyrpro…
541116a 
…ject-rtos#62003
tswaehn added a commit to tswaehn/zephyr that referenced this issue Aug 30, 2023
@tswaehn
dma_sam_xdmac - implemented dma device get_status() - Fixes zephyrpro…
73e78d0 
…ject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
@tswaehn
Copy link
Contributor Author

tswaehn commented Aug 30, 2023

thanks, that is great. I allready had to fix some style related things. 😄

tswaehn added a commit to tswaehn/zephyr that referenced this issue Aug 30, 2023
@tswaehn
drivers: sam dma xdmac: implemented dma device get_status()
8ffbc5d 
the sam xdmac driver does not yet implement the get_status() function. with this
commit the function will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
tswaehn added a commit to tswaehn/zephyr that referenced this issue Sep 8, 2023
@tswaehn
drivers: sam dma xdmac: implemented dma device get_status()
e7eb93f 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
tswaehn added a commit to tswaehn/zephyr that referenced this issue Sep 8, 2023
@tswaehn
drivers: sam dma xdmac: implemented dma device get_status()
f609487 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
tswaehn added a commit to tswaehn/zephyr that referenced this issue Sep 8, 2023
@tswaehn
drivers: sam dma xdmac: implemented dma device get_status()
090e13a 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
tswaehn added a commit to tswaehn/zephyr that referenced this issue Sep 8, 2023
@tswaehn
drivers: sam dma xdmac: implemented dma device get_status()
687a710 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
tswaehn added a commit to tswaehn/zephyr that referenced this issue Sep 8, 2023
@tswaehn
drivers: sam dma xdmac: implemented dma device get_status()
4c26845 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
fabiobaltieri pushed a commit that referenced this issue Sep 9, 2023
@tswaehn @fabiobaltieri
drivers: sam dma xdmac: implemented dma device get_status()
bc695c6 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes #62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
zephyrbot pushed a commit that referenced this issue Sep 9, 2023
@tswaehn @github-actions
drivers: sam dma xdmac: implemented dma device get_status()
8cae3a7 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes #62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
(cherry picked from commit bc695c6)
@fabiobaltieri fabiobaltieri mentioned this issue Sep 9, 2023
Merged
kartben pushed a commit to kartben/zephyr that referenced this issue Sep 11, 2023
@tswaehn @kartben
drivers: sam dma xdmac: implemented dma device get_status()
198aa22 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
coran21 pushed a commit to coran21/zephyr that referenced this issue Sep 21, 2023
@tswaehn @coran21
drivers: sam dma xdmac: implemented dma device get_status()
2c16104 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes zephyrproject-rtos#62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
cfriedt pushed a commit that referenced this issue Nov 17, 2023
@tswaehn @cfriedt
drivers: sam dma xdmac: implemented dma device get_status()
db1ed25 
the sam xdmac driver does not yet implement the
get_status() function. with this commit the function
will be implemented. Fixes #62003

Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
(cherry picked from commit bc695c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: DMA Direct Memory Access Enhancement Changes/Updates/Additions to existing features platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dma_sam_xdmac - implemented dma device get_status() tswaehn/zephyr
2 participants
@tswaehn @henrikbrixandersen