-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for Silicon Labs EFM32PG-STK3402A board #11065
Add initial support for Silicon Labs EFM32PG-STK3402A board #11065
Conversation
boards/arm/efm32pg_stk3402a/board.h
Outdated
#ifndef __INC_BOARD_H | ||
#define __INC_BOARD_H | ||
|
||
#include <soc.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove <soc.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
boards/arm/efm32pg_stk3402a/board.c
Outdated
*/ | ||
|
||
#include <init.h> | ||
#include <board.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"board.h"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
@@ Coverage Diff @@
## master #11065 +/- ##
==========================================
- Coverage 53.11% 48.42% -4.69%
==========================================
Files 218 270 +52
Lines 26869 42126 +15257
Branches 5952 10139 +4187
==========================================
+ Hits 14271 20400 +6129
- Misses 10163 17645 +7482
- Partials 2435 4081 +1646
Continue to review full report at Codecov.
|
f4b76ce
to
985fa08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for doc addition, thanks.
985fa08
to
073f937
Compare
Added flash support and rebased on current master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rework dts_fixup.h for recent CONFIG_ -> DT_ change
if GPIO_GECKO | ||
|
||
config GPIO_GECKO_PORTA | ||
def_bool y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace def_bool y with 'default y'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
6b6b174
to
9975f16
Compare
This includes the Gecko HAL files for the EFM32PG12B SoCs Origin: Silicon Labs Gecko SDK URL: https://github.com/SiliconLabs/Gecko_SDK Version: v5.1.2 (SHA: 938464c68e6c3b2237388a692f767bb0767ec010) Purpose: Add support for Silicon Labs EXX32 SoCs License: Zlib Maintained-by: External Signed-off-by: Gil Benkö <gil.benkoe@pm.me>
This adds the paths of the necessary parts of the SDK to the build infrastructure files. Signed-off-by: Gil Benkö <gil.benkoe@pm.me>
For the EFM32PG12B, the define _EMU_EM23PERNORETAINCTRL_VDAC0DIS_MASK is not availabe. This commit guards its usage with ifdefs. This might be a bug in the gecko SDK or some version incompatibility in the used files. Signed-off-by: Christian Taedcke <hacking@taedcke.com>
9975f16
to
93b166e
Compare
Fixed one issue in dts_fixup.h w/I2C_1 LOCATION & SIZE defines. |
Found the following issues, please fix and resubmit: License/Copyright issues
|
Can you fixup the missing copyright/license on:
I'll chat with @nashif about the zlib license checks. |
@galak Ok, i will add this license and copyright info to this file. |
The Silicon Labs EFM32 Pearl Gecko MCU includes: * Cortex-M4F core at 40MHz * up to 1024KB of flash and 256KB of RAM * multiple low power peripherals Ported from EFM32WG: https://www.silabs.com/documents/public/application-notes/an0918.0-efm32_to_efm32jgpg_migration_guide.pdf Signed-off-by: Gil Benkö <gil.benkoe@pm.me> Signed-off-by: Christian Taedcke <hacking@taedcke.com> Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
This ensures compatibility with Silicon Labs EXX32 MCU Series 1. Signed-off-by: Gil Benkö <gil.benkoe@pm.me> Signed-off-by: Christian Taedcke <hacking@taedcke.com>
The EFM32 Pearl Gecko Starter Kit contains sensors and peripherals demonstrating the usage of the EFM32PG MCU family. This patch adds basic support for this board and is copied from EFM32WG-STK3800. Signed-off-by: Gil Benkö <gil.benkoe@pm.me> Signed-off-by: Christian Taedcke <hacking@taedcke.com>
93b166e
to
9a9f4b7
Compare
The following examples are tested:
This continues #7043, which can be closed now.