Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soc/intel_adsp: Correct linker syntax for ancient binutils #38374

Merged
merged 2 commits into from
Sep 8, 2021
Merged

soc/intel_adsp: Correct linker syntax for ancient binutils #38374

merged 2 commits into from
Sep 8, 2021

Commits on Sep 7, 2021

  1. soc/intel_adsp: Correct linker syntax for ancient binutils 

    Older binutils, like the (nine-year-old!) 2.23 version that powers
many Cadence XCC toolchains, happen not to support the "~" operator to
perform bitwise negation.  And they generate an absolutely hilarious
series of inscrutable error messages when they try to tell you this
fairly simple fact.

Just fold it into the constant.

Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
    Andy Ross committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    df415ff View commit details
    Browse the repository at this point in the history

  2. cmake/compiler/xcc: sched: Support XCC inlining semantics 

    Cadence XCC is based off of a very old 4.2 gcc compiler, which didn't
perfectly support C99 "inline" semantics with respect to
cross-translation-unit inline linkage (which Zephyr does not use, our
inlines are static only) and declaration order.

Fix the one spot where we were calling an inline before its
ALWAYS_INLINE definition, and add a flag to suppress the warning so
CI's trying to build with XCC and -Werror don't flip out.

Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
    Andy Ross committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    176ac85 View commit details
    Browse the repository at this point in the history