ipc_service: Extend API with nocopy functions #44033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocaione
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
hubertmis
requested changes
Mar 21, 2022
nordic-krch
reviewed
Mar 22, 2022
pdunaj
suggested changes
Mar 22, 2022
carlocaione
force-pushed
the
extend_ipc
branch
6 times, most recently
from
3bbe8a1
to
ee614f3
Compare
hubertmis
reviewed
Mar 22, 2022
|
@nordic-krch @pdunaj @hubertmis @arnopo I added some commits to this PR to also adapt the static vrings backend to the new API and changed the current sample so that we use the NOCOPY on one of the tested instances. |
nordic-krch
reviewed
Mar 24, 2022
hubertmis
requested changes
Mar 24, 2022
carlocaione
force-pushed
the
extend_ipc
branch
2 times, most recently
from
89ef492
to
fa4371a
Compare
|
@hubertmis @nordic-krch some changes:
|
hubertmis
requested changes
Mar 25, 2022
nordic-krch
previously approved these changes
Mar 30, 2022
eobalski
reviewed
Mar 31, 2022
nordic-krch
previously approved these changes
Mar 31, 2022
arnopo
requested changes
Mar 31, 2022
And add some more details in documentation. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Add several new functions to the IPC service API: - ipc_service_get_tx_buffer() - ipc_service_drop_tx_buffer() - ipc_service_send_nocopy() - ipc_service_release_rx_buffer() - ipc_service_hold_rx_buffer() This set of function is used to support backends with nocopy capability. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Add the newly introduced NOCOPY capability to the static vrings backend. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
At least for one of the instances, use the NOCOPY feature of the backend. Signed-off-by: Carlo Caione <ccaione@baylibre.com>
arnopo
approved these changes
Apr 1, 2022
nordic-krch
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the discussion at #43924. The idea is that we want to extend the IPC service API to expose several new functions that can be used by backends with nocopy capabilities.
In this PR we also adapt the static vrings backend and the related sample.