civetweb: remove obsolete code #46746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has gone unmaintained and bugs continue to be reported against it. We do not have the resources as a project to maintain this in "odd fixes" mode, and nobody has stepped up to maintain it [1], so sadly this must be removed for now. If anyone would like to see civetweb supported in upstream Zephyr again, they are welcome to add it back, as long as they promise to maintain it going forward. Many thanks to everyone who has contributed to civetweb support in Zephyr while it was here. So long and thanks for all the fish. Fixes: zephyrproject-rtos#45807 Fixes: zephyrproject-rtos#43910 Fixes: zephyrproject-rtos#34226 Fixes: zephyrproject-rtos#46743 [1] https://lists.zephyrproject.org/g/devel/message/8466 Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
mbolivar-nordic
requested review from
rlubos,
gmarull,
KozhinovAlexander,
carlescufi and
cfriedt
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
gmarull
approved these changes
Jun 21, 2022
cfriedt
approved these changes
Jun 21, 2022
stephanosio
approved these changes
Jun 21, 2022
jukkar
approved these changes
Jun 21, 2022
rlubos
approved these changes
Jun 22, 2022
|
Merging this given the approval from @rlubos, especially since this approach was already discussed and approved at the TSC during the v3.1 development phase. If anyone would like to see this restored for v3.2, you can resurrect the module in a PR that also fixes the above four bugs :). |
This was referenced Jun 22, 2022
This was referenced Jun 22, 2022
rexut
added a commit
to tiacsys/bridle
that referenced
this pull request
Jun 12, 2023
Zephyr v3.2 removed this obsolete code. The CivetWeb [1] code has gone unmaintained and bugs continue to be reported against it on Zephyr. We do not have the resources as a project to maintain this in "odd fixes" mode, and nobody has stepped up to maintain it [2], so sadly this must be removed for now, see: zephyrproject-rtos/zephyr#46746 [1] https://github.com/civetweb/civetweb [2] https://lists.zephyrproject.org/g/devel/message/8466 issues: #105 Signed-off-by: Stephan Linz <linz@li-pro.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying #45988 now that we have released v3.1 and nobody has stepped up to maintain civetweb. (I can't reopen the old PR due to GitHub restrictions.)
This code has gone unmaintained and bugs continue to be reported
against it. We do not have the resources as a project to maintain this
in "odd fixes" mode, and nobody has stepped up to maintain it [1], so
sadly this must be removed for now.
If anyone would like to see civetweb supported in upstream Zephyr
again, they are welcome to add it back, as long as they promise to
maintain it going forward.
Many thanks to everyone who has contributed to civetweb support in
Zephyr while it was here. So long and thanks for all the fish.
Fixes: #45807
Fixes: #43910
Fixes: #34226
Fixes: #46743
[1] https://lists.zephyrproject.org/g/devel/message/8466
Signed-off-by: Martí Bolívar marti.bolivar@nordicsemi.no