-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/spi nor flash wp hold pins #58365
Feature/spi nor flash wp hold pins #58365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JPHutchins, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
b6bf6bc
to
c8e5380
Compare
Hi @de-nordic , can you retrigger the "Run tests with twister / twister-build (8) (pull_request_target)" pipeline when you have chance, none of these changes should impact the failing test case. Thanks! |
Please rebase the PR, there seems to be some problems, with CI, unrelated to the changes. |
c8e5380
to
ddce183
Compare
@de-nordic @nashif LMK if you have any questions! |
a0a8f56
to
5e42235
Compare
5e42235
to
dc002fd
Compare
I am not certain how to address the pipeline failure. I am going to rebase again and see if it was already fixed.
|
Adds the wp-gpios & hold-gpios from jedec,spi-nor compatible to spi_nor.c. Signed-off-by: J.P. Hutchins <jp@intercreate.io>
Test spi_nor.c driver builds with or without wp-gpios and hold-gpios. Signed-off-by: J.P. Hutchins <jp@intercreate.io>
-ENODEV returned in 4 cases, logs can distinguish Signed-off-by: J.P. Hutchins <jp@intercreate.io>
Fixes made running tests/drivers/flash Signed-off-by: J.P. Hutchins <jp@intercreate.io>
This change sets write-protect pin disabled BEFORE SW write-protect disable and write-protect pin enabled AFTER SW write-protect enable. Signed-off-by: J.P. Hutchins <jp@intercreate.io>
dc002fd
to
f910020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JPHutchins!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
The jedec,spi-nor compatible defines the use of wp-gpios (Write Protect) and hold-gpios (Hold) pins. Only one of the flash drivers,
spi_flash_at45.c
, initializes and uses wp-gpios and none of them initialize or use hold-gpios.This PR adds initialization and implementation of wp-gpios to the more general
spi_nor.c
driver and initializes but does not implement hold-gpios (set to inactive).Two build tests were added and they can be collected with
west twister -c -p nrf52840dk_nrf52840 -T tests/drivers/flash
.spi_nor.c
has been formatted with clang-format, so it may be helpful to look at the functional changes only in d551e5b.Discussions: