tests: CAP: Add testing of all audio configs #59073

Thalley · 2023-06-08T14:32:05Z

Add test cases to test all audio configurations with
all presets.

Depends on #59061

cvinayak · 2023-06-30T00:47:51Z

tests/bsim/bluetooth/audio/prj.conf

+CONFIG_BT_CTLR_ADVANCED_FEATURES=y
+


Suggested change

CONFIG_BT_CTLR_ADVANCED_FEATURES=y

cvinayak · 2023-06-30T00:48:06Z

tests/bsim/bluetooth/audio/prj.conf


 CONFIG_BT_CTLR_ISO_TX_BUFFERS=3
+
+


Suggested change

# Controller advanced options, while be made defaults in Kconfig based on conformance testing requirements

CONFIG_BT_CTLR_ADVANCED_FEATURES=y

cvinayak · 2023-06-30T00:51:33Z

tests/bsim/bluetooth/audio/prj.conf

 CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=191
 CONFIG_BT_CTLR_ADV_ISO_STREAM_COUNT=1
 CONFIG_BT_CTLR_SYNC_ISO_STREAM_MAX=1

 # Controller Connected ISO configs
 CONFIG_BT_CTLR_CENTRAL_ISO=y
 CONFIG_BT_CTLR_PERIPHERAL_ISO=y
+CONFIG_BT_CTLR_ISOAL_SOURCES=2
+CONFIG_BT_CTLR_ISOAL_SINKS=2
+CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY=y


Once support for flush timeout added, CONFIG_BT_CTLR_CONN_ISO_LOW_LATENCY_POLICY should not be used when tests require to use FT>1

larsgk · 2023-07-17T10:14:03Z

tests/bsim/bluetooth/audio/src/cap_initiator_unicast_test.c

+	for (size_t i = 0; i < param->conn_cnt; i++) {
+		/* Verify conn values */
+		if (param->snk_cnt[i] > CAP_AC_MAX_SNK) {
+			FAIL("Invalid conn_snk_cnt[%zu]: %zu\n", i, param->snk_cnt[i]);


maybe change the printed var to match actual

Add test cases to test all audio configurations with all presets. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>

MariuszSkamra

LGTM, however I added few non-blocking comments

MariuszSkamra · 2023-07-18T08:49:56Z

tests/bsim/bluetooth/audio/src/cap_initiator_unicast_test.c

+	struct bt_conn *conn;
+	int err;
+
+	/* We're only interested in connectable events */


This does not look like something we need in BSIM tests

We have this in the current tests as well; just copied from the common file

MariuszSkamra · 2023-07-18T08:50:14Z

tests/bsim/bluetooth/audio/src/cap_initiator_unicast_test.c

+	/* connect only to devices in close proximity */
+	if (rssi < -70) {
+		FAIL("RSSI too low");
+		return;
+	}


We have this in the current tests as well; just copied from the common file

MariuszSkamra · 2023-07-18T08:51:23Z

tests/bsim/bluetooth/audio/src/cap_initiator_unicast_test.c

+
+	err = bt_conn_le_create(
+		addr, BT_CONN_LE_CREATE_CONN,
+		BT_LE_CONN_PARAM(BT_GAP_INIT_CONN_INT_MIN, BT_GAP_INIT_CONN_INT_MIN, 0, 400),


Suggested change

BT_LE_CONN_PARAM(BT_GAP_INIT_CONN_INT_MIN, BT_GAP_INIT_CONN_INT_MIN, 0, 400),

BT_LE_CONN_PARAM_DEFAULT,

This is specifically restricting the connection interval to 30ms so that is a multiple of both 7.5ms and 10ms SDU interval, which generally provides better chance of scheduling the CIS without conflicts with the ACL :)

MariuszSkamra · 2023-07-18T08:54:29Z

tests/bsim/bluetooth/audio/src/cap_initiator_unicast_test.c

+	printk("stream %p\n", stream);
+	printk("named_preset %p\n", named_preset);


Suggested change

printk("stream %p\n", stream);

printk("named_preset %p\n", named_preset);

printk("stream %p named_preset %p\n", stream, named_preset);

MariuszSkamra · 2023-07-18T09:52:01Z

tests/bsim/bluetooth/audio/src/cap_initiator_unicast_test.c

+	}
+
+	for (size_t i = 0U; i < src_cnt; i++) {
+		src_uni_streams[i] = &unicast_streams[i + snk_cnt];


Hmm, consider some getter function here

Thalley · 2023-07-18T10:48:20Z

@MariuszSkamra We'd like to get this merged soon for the additional testing it provides. Your comments are fine, but I suggest we leave them as is so that this can get merged

Thalley force-pushed the cap_ac_testing branch 5 times, most recently from b9e0a70 to 35a5e06 Compare June 8, 2023 16:07

Thalley changed the title ~~Cap ac testing~~ tests: CAP: Add testing of all audio configs Jun 8, 2023

Thalley force-pushed the cap_ac_testing branch 2 times, most recently from 4a8e1ac to 415ae86 Compare June 9, 2023 10:05

cvinayak self-requested a review June 9, 2023 11:06

Thalley force-pushed the cap_ac_testing branch 4 times, most recently from d3fa80c to 832c6f1 Compare June 9, 2023 12:50

Thalley force-pushed the cap_ac_testing branch 2 times, most recently from 67932ba to 88242a0 Compare June 19, 2023 13:56

Thalley marked this pull request as ready for review June 19, 2023 14:02

Thalley requested review from jhedberg, Vudentz, wopu-ot, alwa-nordic and sjanc as code owners June 19, 2023 14:02

zephyrbot added area: Bluetooth Host area: Bluetooth Audio area: Bluetooth labels Jun 19, 2023

zephyrbot requested review from asbjornsabo, Casper-Bonde-Bose, fredrikdanebjer, hermabe, jori-nordic and kruithofa June 19, 2023 14:03

Thalley marked this pull request as ready for review June 30, 2023 14:42

zephyrbot requested review from alwa-nordic, asbjornsabo, Casper-Bonde-Bose, fredrikdanebjer, hermabe, jhedberg, jori-nordic, kruithofa, larsgk, MariuszSkamra, sjanc, szymon-czapracki, theob-pro and Vudentz June 30, 2023 14:43

cvinayak reviewed Jun 30, 2023

View reviewed changes

Thalley force-pushed the cap_ac_testing branch from 723137e to 5f2d742 Compare July 4, 2023 08:59

Thalley requested a review from cvinayak July 4, 2023 08:59

Thalley force-pushed the cap_ac_testing branch from 5f2d742 to 8b5f256 Compare July 4, 2023 09:02

Thalley mentioned this pull request Jul 6, 2023

LE Audio: CAP long write and read #60092

Merged

larsgk previously approved these changes Jul 17, 2023

View reviewed changes

tests: CAP: Add testing of all audio configs

87e791f

Add test cases to test all audio configurations with all presets. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>

Thalley dismissed larsgk’s stale review via 87e791f July 17, 2023 10:53

Thalley force-pushed the cap_ac_testing branch from 8b5f256 to 87e791f Compare July 17, 2023 10:53

Thalley requested a review from larsgk July 17, 2023 10:53

larsgk approved these changes Jul 17, 2023

View reviewed changes

MariuszSkamra approved these changes Jul 18, 2023

View reviewed changes

fabiobaltieri merged commit b140b70 into zephyrproject-rtos:main Jul 18, 2023
19 checks passed

Thalley deleted the cap_ac_testing branch December 18, 2023 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: CAP: Add testing of all audio configs #59073

tests: CAP: Add testing of all audio configs #59073

Thalley commented Jun 8, 2023 •

edited

Loading

cvinayak Jun 30, 2023

cvinayak Jun 30, 2023

cvinayak Jun 30, 2023

larsgk Jul 17, 2023

MariuszSkamra left a comment

MariuszSkamra Jul 18, 2023

Thalley Jul 18, 2023

MariuszSkamra Jul 18, 2023

Thalley Jul 18, 2023

MariuszSkamra Jul 18, 2023

Thalley Jul 18, 2023

MariuszSkamra Jul 18, 2023

MariuszSkamra Jul 18, 2023

Thalley commented Jul 18, 2023


	# Controller advanced options, while be made defaults in Kconfig based on conformance testing requirements
	CONFIG_BT_CTLR_ADVANCED_FEATURES=y

	BT_LE_CONN_PARAM(BT_GAP_INIT_CONN_INT_MIN, BT_GAP_INIT_CONN_INT_MIN, 0, 400),
	BT_LE_CONN_PARAM_DEFAULT,

		printk("stream %p\n", stream);
		printk("named_preset %p\n", named_preset);

	printk("stream %p\n", stream);
	printk("named_preset %p\n", named_preset);
	printk("stream %p named_preset %p\n", stream, named_preset);

tests: CAP: Add testing of all audio configs #59073

tests: CAP: Add testing of all audio configs #59073

Conversation

Thalley commented Jun 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MariuszSkamra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Thalley commented Jul 18, 2023

Thalley commented Jun 8, 2023 •

edited

Loading