Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: wifi: Introduce Wi-Fi network manager's support #59249

Merged
merged 6 commits into from
Jul 11, 2023
Merged

net: wifi: Introduce Wi-Fi network manager's support #59249

merged 6 commits into from
Jul 11, 2023

Conversation

krish2718
Copy link
Collaborator

@krish2718 krish2718 commented Jun 14, 2023 •
edited
Loading 

This introduces support for Wi-Fi network managers in Zephyr. The
motivation is for the Wi-Fi management layer to work with both
Network managers and offloaded Wi-Fi drivers. The device driver
decides which one to use.

network manager : Apps -> Wi-Fi Mgmt -> Network Manager -> Wi-Fi
interface

offloaded       : Apps -> Wi-Fi Mgmt -> Wi-Fi offloaded interface

Support for multiple network managers has been added, each device can
choose its own network manager and there can be mix and match:

  wlan0 - Offloaded
  wlan1 - Network manager 1
  wlan2 - Network manager 2

@krish2718 krish2718 marked this pull request as draft June 14, 2023 19:36
@krish2718
Copy link
Collaborator Author

This is based on #58869 , will rebase once that gets merged.

@krish2718
net: wifi: Add support to handle Wi-Fi NM's in Wi-Fi management
303cdbe 
Check if a network interface is managed by a network manager before
falling back to offload API.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718
tests: wifi: Add Wi-Fi test suite
442021b 
This adds Wi-Fi tests for both offloaded and newly introduced network
manager managed interface. Only scan op is used to verify the network
manager code.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718
doc: net: Add an entry for Wi-Fi Management
94aa170 
This was missing all along.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718
doc: net: Add an entry about Wi-Fi Network managers
5f52bd4 
Add the entry to convey support for Wi-Fi Network Managers in Zephyr.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@zephyrbot zephyrbot requested a review from ssharks June 29, 2023 19:33
@krish2718 krish2718 mentioned this pull request Jun 29, 2023
Merged
@ssharks
Copy link
Collaborator

ssharks commented Jul 3, 2023

LGTM, I'm not going to give an official approval at this moment as I think it is too important to merge just with 2 green.

nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 5, 2023
@krish2718 @nordicjm
[nrf fromlist] net: wifi: Move Wi-Fi ops to a separate struct
f1d9984 
Decouple interface and Wi-Fi APIs, Wi-Fi APIs are common independent of
Wi-Fi offload or implemented natively (This is preparation for
introducing Native Wi-Fi).

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 5, 2023
@krish2718 @nordicjm
[nrf fromlist] net: wifi: Introduce Wi-Fi network managers
6ef7200 
This introduces support for Wi-Fi network managers in Zephyr. The
motivation is for the Wi-Fi management layer to work with both
Network managers and offloaded Wi-Fi drivers. The device driver
decides which one to use.

network manager : Apps -> Wi-Fi Mgmt -> Network Manager -> Wi-Fi
interface

offloaded       : Apps -> Wi-Fi Mgmt -> Wi-Fi offloaded interface

Support for multiple network managers has been added, each device can
choose its own network manager and there can be mix and match:

  wlan0 - Offloaded
  wlan1 - Network manager 1
  wlan2 - Network manager 2

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 5, 2023
@krish2718 @nordicjm
[nrf fromlist] net: wifi: Add support to handle Wi-Fi NM's in Wi-Fi m…
80f1eb3 
…anagement

Check if a network interface is managed by a network manager before
falling back to offload API.

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 5, 2023
@krish2718 @nordicjm
[nrf fromlist] tests: wifi: Add Wi-Fi test suite
7fd8d50 
This adds Wi-Fi tests for both offloaded and newly introduced network
manager managed interface. Only scan op is used to verify the network
manager code.

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 5, 2023
@krish2718 @nordicjm
[nrf fromlist] doc: net: Add an entry for Wi-Fi Management
2dcb7ab 
This was missing all along.

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 5, 2023
@krish2718 @nordicjm
[nrf fromlist] doc: net: Add an entry about Wi-Fi Network managers
52222dc 
Add the entry to convey support for Wi-Fi Network Managers in Zephyr.

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
de-nordic pushed a commit to de-nordic/sdk-zephyr that referenced this pull request Jul 10, 2023
@krish2718 @de-nordic
[nrf fromlist] net: wifi: Move Wi-Fi ops to a separate struct
28773e8 
Decouple interface and Wi-Fi APIs, Wi-Fi APIs are common independent of
Wi-Fi offload or implemented natively (This is preparation for
introducing Native Wi-Fi).

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit f1d9984)
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic pushed a commit to de-nordic/sdk-zephyr that referenced this pull request Jul 10, 2023
@krish2718 @de-nordic
[nrf fromlist] net: wifi: Introduce Wi-Fi network managers
46ebb54 
This introduces support for Wi-Fi network managers in Zephyr. The
motivation is for the Wi-Fi management layer to work with both
Network managers and offloaded Wi-Fi drivers. The device driver
decides which one to use.

network manager : Apps -> Wi-Fi Mgmt -> Network Manager -> Wi-Fi
interface

offloaded       : Apps -> Wi-Fi Mgmt -> Wi-Fi offloaded interface

Support for multiple network managers has been added, each device can
choose its own network manager and there can be mix and match:

  wlan0 - Offloaded
  wlan1 - Network manager 1
  wlan2 - Network manager 2

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit 6ef7200)
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic pushed a commit to de-nordic/sdk-zephyr that referenced this pull request Jul 10, 2023
@krish2718 @de-nordic
[nrf fromlist] net: wifi: Add support to handle Wi-Fi NM's in Wi-Fi m…
c48fd14 
…anagement

Check if a network interface is managed by a network manager before
falling back to offload API.

Upstream-Pr: zephyrproject-rtos/zephyr#59249

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit 80f1eb3)
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@carlescufi carlescufi merged commit 521e129 into zephyrproject-rtos:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi carlescufi approved these changes

@rlubos rlubos rlubos approved these changes

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@Kludentwo Kludentwo Awaiting requested review from Kludentwo Kludentwo is a code owner

@loicpoulain loicpoulain Awaiting requested review from loicpoulain loicpoulain is a code owner

@nandojve nandojve Awaiting requested review from nandojve nandojve is a code owner

@mniestroj mniestroj Awaiting requested review from mniestroj mniestroj is a code owner

@LucasTambor LucasTambor Awaiting requested review from LucasTambor

@marekmatej marekmatej Awaiting requested review from marekmatej

@sylvioalves sylvioalves Awaiting requested review from sylvioalves

@uLipe uLipe Awaiting requested review from uLipe

@nashif nashif Awaiting requested review from nashif

@ssharks ssharks Awaiting requested review from ssharks

Assignees

@rlubos rlubos

Labels
area: Networking area: Wi-Fi Wi-Fi platform: ESP32 Espressif ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krish2718 @ssharks @carlescufi @rlubos @zephyrbot