-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arm: Add support for ARM FK7B0M1-VBT6 V1.0 board #65441
boards: arm: Add support for ARM FK7B0M1-VBT6 V1.0 board #65441
Conversation
9f11541
to
9f5f202
Compare
9f5f202
to
befd935
Compare
befd935
to
fc37aaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks good, thanks! A few extra comments on my side + you should also please squash the documentation commit with the one introducing the board, as new boards are typically added as just one commit
boards/arm/fk7b0m1_vbt6/board.cmake
Outdated
|
||
include(${ZEPHYR_BASE}/boards/common/openocd.board.cmake) | ||
include(${ZEPHYR_BASE}/boards/common/stm32cubeprogrammer.board.cmake) | ||
include(${ZEPHYR_BASE}/boards/common/jlink.board.cmake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a newline at the end of the file (not sure why CI doesn't catch this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Let me know if any other modification is needed.
|
||
FK7B0M1-VBT6 (Credit: FANKE Technology Co., Ltd) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you have extra blank lines here and there that would be nice to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
fc37aaf
to
53feee2
Compare
53feee2
to
716c99f
Compare
|
||
&clk_hse { | ||
clock-frequency = <DT_FREQ_M(25)>; | ||
status = "okay"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be checked on schematics : if External 25MHz crystal oscillator. should the hse-bypass
be set ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing my earlier comments, just spotted a couple extra (and minor) issues. Thanks!
Adds the device trees, Kconfig, and documentation files. The following features have been confirmed working on hardware: * LED * Button * UART Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
Add vendor prefix fanke FANKE Technology Co., Ltd. Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
716c99f
to
51db4ca
Compare
The following features have been tested and confirmed to work on the hardware:
west flash
command