Enable tristate Kconfig options #67105
Conversation
There was a problem hiding this comment.
I see the potential of having tristate options in Zephyr, and it's OK to keep the CONFIG_MODULES / =m names as they are widely used in Kconfig-based projects.
Minor tip: I would add a depends on LLEXT so that it is hidden unless dynamic code loading is actually used in the build.
There was a problem hiding this comment.
lgtm.
As this setting is currently intended for llext then current location is acceptable,
but has been considered if subsys/Kconfig is the right location for this setting?
Another option could be under Build and Link features where other settings related to build and configuration is controlled, ref:
Line 825 in c25ac48
Approved for now, as we can always move the setting later if desired.
|
Thanks for the reviews so far! In principle I'm not against any of the proposals - neither against adding a |
|
The Compliance Check is complaining about:
Indeed, the |
|
would be great and very helpful to have a usecase and a sample of this kconfig being used. Just throwing in a kconfig in a PR is usually not enough.... |
@nashif the use-case is LLEXT and a sample is SOF thesofproject/sof@614ec42#diff-44c49245e3507ea76cafeca22e652e4f30a24495a147d0beb5681a7bad5b0b71 |
Same problem in related: I think the biggest I understand brand new features are made of many different parts and that they can't all be merged at the same time. On the other hand, there also seems to be a common misconception that the main branch is the only way to share incomplete bits still in progress. |
@marc-hb I don't think it's the same "problem" - @nashif commented on "Just throwing in a kconfig in a PR" and that other PR doesn't add any Kconfig options.
I agree that CMake for llext is a bit difficult now, but I wouldn't relate it to this PR. Again: this is purely to trigger scripts/kconfig/kconfiglib.py to accept tristate Kconfig options, nothing else. As is it's not directly related to llext or to any other subsystem. |
|
twister seems to have experienced a melt down on this PR, should I re-push to have a clean CI run? |
kconfiglib.py has a hard dependency on CONFIG_MODULES to support 'm' values for tristate Kconfig options. It's a logical companion for but can also be used with other configurations. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add a tristate Kconfig option to the llext hello-world twister test. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
|
Switch to assignee just to confirm about the option in the top level subsys Kconfig. @tejlmand can you reconfirm please? |
kconfiglib.py has a hard dependency on CONFIG_MODULES to support 'm' values for tristate Kconfig options. It's a logical companion for but can also be used with other configurations.