llext: actual test rework #67906
Merged
llext: actual test rework #67906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so LLEXT_TEST_HELLO is enabled by default, and it is actually compiled only when the config is enabled. The check for MODULES==y and LLEXT_TEST_HELLO!=m is redundant, as the Twister machinery already causes an error when Kconfig flags specified in the YAML file are coerced to different values. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
This patch reworks the YAML files for the llext samples and tests to share a common restriction list. Also, using an arch-specific config to disable the MPU for the ARM architecture only, there is no need to duplicate the test cases per architecture. Use this to enable the "writable" test case for the ARM architecture and separate the "modules_enabled" case to test building as a module. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
In preparation for multiple tests, move the current hello_world test to its own subdirectory. Also, merge the llext compilation in the parent CMakeLists.txt. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
marc-hb
approved these changes
Jan 23, 2024
teburd
approved these changes
Jan 23, 2024
|
|
||
| set(HELLO_WORLD_LLEXT ${llext_bin_file} PARENT_SCOPE) | ||
| add_llext_target(hello_world |
There was a problem hiding this comment.
this is quite nice not having to write a custom cmake file now for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #67431 containing the llext-test-related commits that were already reviewed during that discussion. With this PR the
tests/llextsubdir can have multiple independent tests with minimal duplication.