Improve STM32H7B3I DK configuration to run LVGL #68254

CharlesDias · 2024-01-29T22:39:10Z

Using the default configuration, the FPS range is 12 to 17, while CPU usage often reaches maximum capacity.

document_5026149297339499817.mp4

After updating the defconfig, it was possible to keep the 33 FSP with less CPU usage.

enable ICache, DCache, and cache management.
enable Chrom-ART.
enable double frame buffer and full refresh.
set bits per pixel to 16 if the RGB565 is used.

document_5026149297339499816.mp4

erwango

Thanks @CharlesDias for this contribution.
Please update documentation as well, otherwise it is fine to me.

As a side note, I'd like we can make this less board specific and move whatever is possible to soc/arm/st_stm32/stm32h7, but that can be done in a next step. Having this part of V3.6 would already be a good deal.

CharlesDias · 2024-01-30T12:29:26Z

Dear @erwango,

I saw that the job **Run tests with twister / twister-build (1) (pull_request_target) ** is failing because of some functions that are declared but not used.

Could you give me some tip? Thank you.

modules/lvgl/CMakeFiles/modules__lvgl.dir/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c.obj -c /__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:689:28: error: '_lv_gpu_stm32_dma2d_invalidate_cache' defined but not used [-Werror=unused-function]
  689 | LV_STM32_DMA2D_STATIC void _lv_gpu_stm32_dma2d_invalidate_cache(uint32_t address, lv_coord_t offset, lv_coord_t width,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:606:28: error: '_lv_draw_stm32_dma2d_copy_buffer' defined but not used [-Werror=unused-function]
  606 | LV_STM32_DMA2D_STATIC void _lv_draw_stm32_dma2d_copy_buffer(const lv_color_t * dest_buf, lv_coord_t dest_stride,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:371:28: error: 'lv_gpu_stm32_dma2d_wait_cb' defined but not used [-Werror=unused-function]
  371 | LV_STM32_DMA2D_STATIC void lv_gpu_stm32_dma2d_wait_cb(lv_draw_ctx_t * draw_ctx)
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:333:32: error: 'lv_draw_stm32_dma2d_img' defined but not used [-Werror=unused-function]
  333 | LV_STM32_DMA2D_STATIC lv_res_t lv_draw_stm32_dma2d_img(lv_draw_ctx_t * draw_ctx, const lv_draw_img_dsc_t * img_dsc,
      |                                ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.

CharlesDias · 2024-01-30T12:37:51Z

Thanks @CharlesDias for this contribution. Please update documentation as well, otherwise it is fine to me.

As a side note, I'd like we can make this less board specific and move whatever is possible to soc/arm/st_stm32/stm32h7, but that can be done in a next step. Having this part of V3.6 would already be a good deal.

Dear @erwango, could you clarify which documentation part I have to update? Thank you!

ajarmouni-st · 2024-01-30T12:44:19Z

Thanks @CharlesDias for this contribution. Please update documentation as well, otherwise it is fine to me.
As a side note, I'd like we can make this less board specific and move whatever is possible to soc/arm/st_stm32/stm32h7, but that can be done in a next step. Having this part of V3.6 would already be a good deal.

Dear @erwango, could you clarify which documentation part I have to update? Thank you!

https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arm/stm32h7b3i_dk/doc/index.rst

Here is an example https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arm/stm32f746g_disco/doc/index.rst

erwango · 2024-01-30T13:05:51Z

Dear @erwango,

I saw that the job **Run tests with twister / twister-build (1) (pull_request_target) ** is failing because of some functions that are declared but not used.

Could you give me some tip? Thank you.

modules/lvgl/CMakeFiles/modules__lvgl.dir/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c.obj -c /__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:689:28: error: '_lv_gpu_stm32_dma2d_invalidate_cache' defined but not used [-Werror=unused-function]
  689 | LV_STM32_DMA2D_STATIC void _lv_gpu_stm32_dma2d_invalidate_cache(uint32_t address, lv_coord_t offset, lv_coord_t width,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:606:28: error: '_lv_draw_stm32_dma2d_copy_buffer' defined but not used [-Werror=unused-function]
  606 | LV_STM32_DMA2D_STATIC void _lv_draw_stm32_dma2d_copy_buffer(const lv_color_t * dest_buf, lv_coord_t dest_stride,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:371:28: error: 'lv_gpu_stm32_dma2d_wait_cb' defined but not used [-Werror=unused-function]
  371 | LV_STM32_DMA2D_STATIC void lv_gpu_stm32_dma2d_wait_cb(lv_draw_ctx_t * draw_ctx)
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/zephyr/modules/lib/gui/lvgl/src/draw/stm32_dma2d/lv_gpu_stm32_dma2d.c:333:32: error: 'lv_draw_stm32_dma2d_img' defined but not used [-Werror=unused-function]
  333 | LV_STM32_DMA2D_STATIC lv_res_t lv_draw_stm32_dma2d_img(lv_draw_ctx_t * draw_ctx, const lv_draw_img_dsc_t * img_dsc,
      |                                ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.

I'd suggest asking in discord Infrastructure channel. It should be possible not enabling this option when compiling external libraries. This is likely what is done when compiling TF-M.

CharlesDias · 2024-01-30T18:04:42Z

Dear @erwango and @ajarmouni-st,

I updated the documentation. Let me know if I need to do something else. Also, I posted the issue related to "Run tests with twister / twister-build (1) (pull_request_target)" on discord Infrastructure channel.

Thanks!

CharlesDias · 2024-01-30T19:50:57Z

Related to the CI job that failed, I verified that the call to the lv_gpu_stm32_dma2d_wait_cb and lv_draw_stm32_dma2d_img functions were commented out on zephyrproject-rtos/lvgl@7cfca5d, and the _lv_draw_stm32_dma2d_copy_buffer is never called.

In this case, those functions are not called anymore. Also, I ran the console commands:

grep -r --include=*.{c,h} --include=CMakeLists.txt "_lv_draw_stm32_dma2d_copy_buffer" .
grep -r --include=*.{c,h} --include=CMakeLists.txt "lv_gpu_stm32_dma2d_wait_cb" .
grep -r --include=*.{c,h} --include=CMakeLists.txt "lv_draw_stm32_dma2d_img" .

Within the Zephyr project, and no modules, drivers, etc., call these functions.

Should these functions be removed?

CharlesDias · 2024-01-30T21:21:18Z

I opened this PR (zephyrproject-rtos/lvgl#50) to remove the unused functions.

erwango · 2024-01-30T21:45:20Z

I opened this PR (zephyrproject-rtos/lvgl#50) to remove the unused functions.

If this is the actual fix, it has to be fixed in upstream lvgl first.

CharlesDias · 2024-02-13T13:26:37Z

Dear @erwango and @faxe1008,

The lvgl/lvgl#5561 has been merged into the upstream LVGL project, but not yet into https://github.com/zephyrproject-rtos/lvgl. Will the zephyrproject-rtos/lvgl repository only be updated when a new LVGL version becomes available?

Thanks.

faxe1008 · 2024-02-13T13:33:01Z

@CharlesDias yes as soon as 8.3.12 is released we will update our fork. I would advise against tracking unreleased changes if the fix is not mission critical.

CharlesDias · 2024-03-05T20:51:06Z

Solved conflicts.

boards/st/stm32h7b3i_dk/doc/index.rst

faxe1008 · 2024-03-12T18:47:08Z

@CharlesDias Great news, there will most likely be a LVGL release 8.4 that incorporates your fixes on 17 of March :^). Will follow up with a sync PR on our fork asap. Would love to see this one get merged.

boards/st/stm32h7b3i_dk/dc_ram.ld

erwango · 2024-03-13T12:33:59Z

@CharlesDias What's the status of this PR ? I don't see CI errors anymore but LVGL fix is apparently not yet merged.
I'm willing to approve, but I'd like to avoid it is merged while not fully ready.

CharlesDias · 2024-03-13T13:43:33Z

@CharlesDias What's the status of this PR ? I don't see CI errors anymore but LVGL fix is apparently not yet merged. I'm willing to approve, but I'd like to avoid it is merged while not fully ready.

@erwango, on my local build, the warnings still exist. I don't know why the CI doesn't catch them anymore. I tested with samples/modules/lvgl/demos -- -DCONFIG_LV_Z_DEMO_MUSIC=y and it seems good.

erwango · 2024-03-15T14:42:40Z

@CharlesDias What's the status of this PR ? I don't see CI errors anymore but LVGL fix is apparently not yet merged. I'm willing to approve, but I'd like to avoid it is merged while not fully ready.

@erwango, on my local build, the warnings still exist. I don't know why the CI doesn't catch them anymore. I tested with samples/modules/lvgl/demos -- -DCONFIG_LV_Z_DEMO_MUSIC=y and it seems good.

Ok, let's wait the warning to be fixed to be on the safe side.
I'm adding a DNM label. Please remove it (or ping me if you can't do it) once this is actually solved in tree.

faxe1008 · 2024-03-20T07:50:12Z

@CharlesDias Yesterday 8.4.0 was released. I opened PRs in the module and the main repo. Feel free to also check that your changes still work as intended :^)
#70470

CharlesDias · 2024-03-22T17:13:04Z

@CharlesDias Yesterday 8.4.0 was released. I opened PRs in the module and the main repo. Feel free to also check that your changes still work as intended :^)
#70470

Hi, @faxe1008. I tested using the #70470 and still works! And the warnings disappeared. :-)

faxe1008

@CharlesDias the update of the module was just merged. Noticed the thing with the copyright, but this also provides you with an opportunity to retrigger CI :^)

faxe1008 · 2024-03-25T11:54:39Z

boards/st/stm32h7b3i_dk/CMakeLists.txt

@@ -0,0 +1,9 @@
+#
+# Copyright 2023 BrainCo Inc.


Nit: copied the Copyright :^)

Done. Thanks!

Update Kconfig to improve LVGL Demo performance. - enable ICache, DCache, and cache management. - enable Chrom-ART. - enable double frame buffer and full refresh. - set bits per pixel to 16. Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>

zephyrbot added the platform: STM32 ST Micro STM32 label Jan 29, 2024

zephyrbot requested review from ABOSTM, Desvauxm-st, erwango, FRASTM, gautierg-st and GeorgeCGV January 29, 2024 22:39

zephyrbot assigned erwango Jan 29, 2024

CharlesDias changed the title ~~Fix STM32H7B3I DK configuration to run LVGL~~ Improve STM32H7B3I DK configuration to run LVGL Jan 29, 2024

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch 2 times, most recently from 7acc510 to c10d188 Compare January 29, 2024 22:51

ajarmouni-st added area: Display Enhancement Changes/Updates/Additions to existing features labels Jan 30, 2024

erwango requested a review from ajarmouni-st January 30, 2024 10:15

erwango reviewed Jan 30, 2024

View reviewed changes

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch from c10d188 to 3e8f1c5 Compare January 30, 2024 15:49

zephyrbot added the area: Samples Samples label Jan 30, 2024

zephyrbot requested review from kartben and nashif January 30, 2024 15:49

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch 2 times, most recently from d39f396 to 40d2111 Compare January 30, 2024 16:51

CharlesDias mentioned this pull request Jan 30, 2024

stm32_dma2d: (fix) remove unused functions zephyrproject-rtos/lvgl#50

Closed

erwango added this to the v3.7.0 milestone Feb 13, 2024

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch from 40d2111 to a23570f Compare March 5, 2024 20:50

ajarmouni-st reviewed Mar 6, 2024

View reviewed changes

boards/st/stm32h7b3i_dk/doc/index.rst Outdated Show resolved Hide resolved

ajarmouni-st reviewed Mar 6, 2024

View reviewed changes

boards/st/stm32h7b3i_dk/doc/index.rst Outdated Show resolved Hide resolved

ajarmouni-st reviewed Mar 6, 2024

View reviewed changes

boards/st/stm32h7b3i_dk/doc/index.rst Show resolved Hide resolved

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch from a23570f to 4579b38 Compare March 6, 2024 11:33

faxe1008 mentioned this pull request Mar 12, 2024

8.3 PXP add zephyr support lvgl/lvgl#5838

Merged

erwango reviewed Mar 13, 2024

View reviewed changes

boards/st/stm32h7b3i_dk/dc_ram.ld Outdated Show resolved Hide resolved

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch from 4579b38 to 13a1202 Compare March 13, 2024 11:45

erwango previously approved these changes Mar 15, 2024

View reviewed changes

erwango added the DNM This PR should not be merged (Do Not Merge) label Mar 15, 2024

faxe1008 mentioned this pull request Mar 20, 2024

Update LVGL to 8.4 zephyrproject-rtos/lvgl#51

Merged

faxe1008 removed the DNM This PR should not be merged (Do Not Merge) label Mar 25, 2024

faxe1008 reviewed Mar 25, 2024

View reviewed changes

CharlesDias dismissed erwango’s stale review via 8cf531b March 25, 2024 20:21

CharlesDias force-pushed the stm32h7b3i_dk_improve_lvgl branch from 13a1202 to 8cf531b Compare March 25, 2024 20:21

faxe1008 approved these changes Mar 25, 2024

View reviewed changes

erwango approved these changes Mar 26, 2024

View reviewed changes

fabiobaltieri merged commit a0ddba5 into zephyrproject-rtos:main Mar 26, 2024
21 checks passed

CharlesDias mentioned this pull request Jun 25, 2024

boards: shields: mb1166_a09: disable default STM32_LTDC_RGB888 configuration #74874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve STM32H7B3I DK configuration to run LVGL #68254

Improve STM32H7B3I DK configuration to run LVGL #68254

CharlesDias commented Jan 29, 2024

erwango left a comment

CharlesDias commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

ajarmouni-st commented Jan 30, 2024 •

edited

Loading

erwango commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

erwango commented Jan 30, 2024

CharlesDias commented Feb 13, 2024

faxe1008 commented Feb 13, 2024

CharlesDias commented Mar 5, 2024

faxe1008 commented Mar 12, 2024

erwango commented Mar 13, 2024

CharlesDias commented Mar 13, 2024

erwango commented Mar 15, 2024

faxe1008 commented Mar 20, 2024

CharlesDias commented Mar 22, 2024

faxe1008 left a comment

faxe1008 Mar 25, 2024

CharlesDias Mar 25, 2024

Improve STM32H7B3I DK configuration to run LVGL #68254

Improve STM32H7B3I DK configuration to run LVGL #68254

Conversation

CharlesDias commented Jan 29, 2024

erwango left a comment

Choose a reason for hiding this comment

CharlesDias commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

ajarmouni-st commented Jan 30, 2024 • edited Loading

erwango commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

CharlesDias commented Jan 30, 2024

erwango commented Jan 30, 2024

CharlesDias commented Feb 13, 2024

faxe1008 commented Feb 13, 2024

CharlesDias commented Mar 5, 2024

faxe1008 commented Mar 12, 2024

erwango commented Mar 13, 2024

CharlesDias commented Mar 13, 2024

erwango commented Mar 15, 2024

faxe1008 commented Mar 20, 2024

CharlesDias commented Mar 22, 2024

faxe1008 left a comment

Choose a reason for hiding this comment

faxe1008 Mar 25, 2024

Choose a reason for hiding this comment

CharlesDias Mar 25, 2024

Choose a reason for hiding this comment

ajarmouni-st commented Jan 30, 2024 •

edited

Loading