kernel/userspace: Fix dynamic thread stack allocation at userspace #69540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
peter-mitsis
previously approved these changes
Feb 28, 2024
nashif
previously approved these changes
Feb 28, 2024
dcpleung
previously approved these changes
Feb 28, 2024
|
LGTM - just one minor suggestion |
@cfriedt looks like you may have forgotten to add it to your review |
cfriedt
reviewed
Feb 29, 2024
| - CONFIG_DYNAMIC_THREAD_POOL_SIZE=0 | ||
| - CONFIG_DYNAMIC_THREAD_ALLOC=y | ||
| - CONFIG_USERSPACE=y | ||
| - CONFIG_DYNAMIC_OBJECTS=y |
There was a problem hiding this comment.
CONFIG_DYNAMIC_OBJECTS might be better off in prj.conf, in which case this 011 case should be the same as the other.
It should be activated whenever userspace is active in these tests in any case.
teburd
previously approved these changes
Feb 29, 2024
It wasn't saving adjusted stack size at either the private stack or the k_object, thus failing subsequent checks. Test added to check for this case and prevent regressions. Signed-off-by: Ederson de Souza <ederson.desouza@intel.com>
edersondisouza
dismissed stale reviews from teburd, dcpleung, nashif, and peter-mitsis
via
50a0b4d
edersondisouza
force-pushed
the
fix-dyn-stack-userspace
branch
from
8604f2f
to
50a0b4d
Compare
|
v2:
|
edersondisouza
requested review from
cfriedt,
teburd,
nashif,
dcpleung and
peter-mitsis
dcpleung
approved these changes
Feb 29, 2024
cfriedt
approved these changes
Feb 29, 2024
teburd
approved these changes
Feb 29, 2024
|
Any comments, @andyross? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't saving adjusted stack size at either the private stack or the k_object, thus failing subsequent checks.
Test added to check for this case and prevent regressions.