[Backport v2.7-branch] backport #65546: userspace: Additional checks in K_SYSCALL_MEMORY #69637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Z_DETECT_POINTER_OVERFLOW() macro is intended detect whether or not a buffer spans a region of memory that goes beyond the highest possible address (thereby overflowing the pointer). Signed-off-by: Peter Mitsis <peter.mitsis@intel.com>
This macros needed additional checks before invoking arch_buffer_validate. - size can not be less then 0. Some functions invoke this macro using signed type which will be promote to unsigned when invoking arch_buffer_validate. We need to do an early check. - We need to check for possible overflow, since a malicious user application could use a negative number that would be promoted to a big value that would cause a integer overflow when adding it to the buffer address, leading to invalid checks. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Since K_SYSCALL_MEMORY can be called with signed/unsigned size types, if we check if size >= 0, static anlysis will complain about it when size in unsigned. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
ceolin
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
cfriedt
changed the title
d3zd3z
approved these changes
Mar 1, 2024
cfriedt
approved these changes
Mar 1, 2024
|
Assuming that the doc build failure is unrelated. |
cfriedt
merged commit e9fcfa1
into
zephyrproject-rtos:v2.7-branch
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #65546 for
v2.7-branch.Fixes #66775