drivers: gpio: max22190: Add MAX22190 octal input with diagnostics #71141
Conversation
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
galak,
henrikbrixandersen,
MaureenHelm,
microbuilder and
mnkp
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
2 times, most recently
from
5ac5f2c
to
823f4da
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
823f4da
to
82aeb3f
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
2 times, most recently
from
d903a24
to
1aa75d3
Compare
| type: phandle-array | ||
| max22190-mode: | ||
| type: int | ||
| default: 1 |
There was a problem hiding this comment.
default value requires justification in description (same for other properties)
There was a problem hiding this comment.
sure, I add clarification for all. Could you take a look if it is enough ?
There was a problem hiding this comment.
I think for the mode you should just remove the default value, it needs to be specified in the board DT, it is hardwired signals on the board after all, needs to be described
There was a problem hiding this comment.
I specified default value because this was mode set on the devkit it self, but it make sens to have it in DT.
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
1aa75d3
to
f589043
Compare
| type: phandle-array | ||
| max22190-mode: | ||
| type: int | ||
| default: 1 |
There was a problem hiding this comment.
I think for the mode you should just remove the default value, it needs to be specified in the board DT, it is hardwired signals on the board after all, needs to be described
| description: | | ||
| Wire break functionality is enabled by default on all channels. | ||
| WBE bit in all Filter registers stand for wire break enable on each | ||
| channel, so to enable WB functionality set 1. |
There was a problem hiding this comment.
I think you should clarify that this default value is not the default value of the hardware
There was a problem hiding this comment.
I think it is better all filter-wbes , filter-fbps and filter-delays to have for default values from datasheet.
This mean:
- wire break - 0 disable
- fbps - 1 bypass
- delays - 50
Value which was set is the one which is in use in case WBE is 1. In that case delays is 20000.
There was a problem hiding this comment.
okay, but now the description seems wrong, it still says set 1? is it intentional, it seems unclear at best
There was a problem hiding this comment.
Maybe my language here is not quiet clear. I want to state that by default every channel is with disabled Wire Break functionality - WBEx bit = 0.
To enable specific channel Wire Break functionality WBEx bit = 1.
Example for channel first 4 channels enabled WB and last 4 disabled WB
[ 1, 1, 1, 1, 0, 0, 0, 0]
If you have some suggestions how to make it clearer please share it.
| type: array | ||
| default: [1, 1, 1, 1, 1, 1, 1, 1] | ||
| description: | | ||
| By default all channels are set to bypass mode from documentation. |
There was a problem hiding this comment.
word this more like "The default value corresponds to the default value of the hardware"
| type: array | ||
| default: [20000, 20000, 20000, 20000, 20000, 20000, 20000, 20000] | ||
| description: | | ||
| Default value in documentation is 20ms which corespond to 200000us. |
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
f589043
to
b154371
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
b154371
to
b5cbd91
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
3 times, most recently
from
21d8d38
to
36b0edc
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
36b0edc
to
d27c10b
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
2 times, most recently
from
ca56cbb
to
95c8873
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
95c8873
to
7bb5258
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
7bb5258
to
5a5e7b5
Compare
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
5a5e7b5
to
fdcc0f6
Compare
|
Thanks @MaureenHelm ,typos are fixed and branch is rebased on latest main |
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
2 times, most recently
from
27326ae
to
58a384e
Compare
Add max22190 gpio driver with input functionality, since device support only input without output. Implemented diagnostic funcionality for all 8 channels which include various check to over/under voltage and wire break. Filtering configuration is done from devicetree on per channel bases and is configured on chip start. In case of some fault condition occure FAULT pin drive LOW which prop to FAULT registers to be read. Data is stored in data structure for furter analizes and ERR message is prited in console. Signed-off-by: Stoyan Bogdanov <sbogdanov@baylibre.com>
bogdanovs
force-pushed
the
adi-max22190-gpio
branch
from
58a384e
to
7791270
Compare
Add max22190 gpio driver with input functionality, since device support only input with output.
Implemented diagnostic funcionality for all 8 channels which include various check to over/under voltage and wire break. Filtering configuration is done from devicetree on per channel bases and is configured on chip start.
In case of some fault condition occure FAULT pin drive LOW which prop to FAULT registers to be read. Data is stored in data structure for furter analizes and ERR message is prited in console.