drivers: can: add support for Nordic nRF MCAN #73386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
manifest
manifest-hal_nordic
DNM
gmarull
force-pushed
the
nordic-can
branch
2 times, most recently
from
aec56dd
to
1740b4c
Compare
carlescufi
added a commit
to carlescufi/docker-image
that referenced
this pull request
May 28, 2024
The new version is required for the introduction of nRF MCAN: zephyrproject-rtos/zephyr#73386 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
>=5.3.0 is required for proper CAN support. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add binding for Nordic CAN peripheral, based on the Bosch MCAN IP. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Define CAN120 instance. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Configure CAN120 MCAN core registers as non-cachable to prevent D-Cache from inhibiting volatile accesses to the CAN120 MCAN registers. Also apply non-cachable attribute to the message ram region. Even though the MCAN driver handles cache invalidation/flushing, MPU faults are still triggered (to be investigated). Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
So that we can configure CAN pins. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
Add driver for the Nordic CAN peripheral, based on Bosch MCAN IP. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
zephyrbot
added
platform: nRF
zephyrbot
requested review from
alexanderwachter,
decsny,
galak,
jaz1-nordic,
kl-cruz,
magp-nordic,
martinjaeger,
nika-nordic and
str4t0m
henrikbrixandersen
previously approved these changes
May 29, 2024
Enable canpll (required to clock CAN), and can120 instance, routed to pins P9.4 and P9.5. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
|
last push: added |
| #define CAN_INTEN offsetof(NRF_CAN_Type, INTEN) | ||
|
|
||
| struct can_nrf_config { | ||
| uint32_t wrapper; |
There was a problem hiding this comment.
Just out of curiosity, what is this wrapper? Is it something related to multicore and irq?
There was a problem hiding this comment.
nope, it's just the nordic-specific thin layer on top of the Bosch MCAN IP (eg IRQ enablement, events, etc.)
alexanderwachter
approved these changes
May 30, 2024
henrikbrixandersen
approved these changes
May 30, 2024
stephanosio
pushed a commit
to zephyrproject-rtos/docker-image
that referenced
this pull request
May 30, 2024
The new version is required for the introduction of nRF MCAN: zephyrproject-rtos/zephyr#73386 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Late this year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.