modules: hostap: 11k/v/r roaming support #78684

nxf58150 · 2024-09-19T06:31:21Z

Added 11k/v/r roaming support.

zephyrbot · 2024-09-19T06:37:42Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
hostap	zephyrproject-rtos/hostap@`f6792cb`	zephyrproject-rtos/hostap#38	zephyrproject-rtos/hostap#38/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nxf58150 · 2024-09-24T06:39:16Z

The 11kvr roaming RFC link: #76307

jukkar · 2024-09-25T06:53:48Z

modules/hostap/src/supp_api.c

+	if (params && strlen(params->ssid)) {
+		if (strlen(params->ssid) > WIFI_SSID_MAX_LEN) {


We could use here a temporary variable for ssid length, now the length is calculated three times in this function which is pointless.

Added a local variable for ssid length. Thanks!

jukkar · 2024-09-25T06:58:19Z

subsys/net/l2/wifi/wifi_shell.c

+
+	context.sh = sh;
+
+	if (argc != 2) {


Could we show the current 11k status if user does not give a parameter. And only show the warning if user gives wrong number of parameters.

Updated. The new command "wifi 11k" will be used to get 11k status (enabled or disabled) if no parameter was given.

jukkar · 2024-09-25T07:00:53Z

subsys/net/l2/wifi/wifi_shell.c

@@ -2909,6 +2978,10 @@ SHELL_STATIC_SUBCMD_SET_CREATE(wifi_commands,
 		cmd_wifi_btm_query,
 		2, 0),
 #endif
+	SHELL_CMD_ARG(11k_enable, NULL, "<0/1>\n",


I am not a big fan of just giving 0/1 here, it would be more logical if user could just say "enable" or "disable".
So wifi 11k enable or wifi 11k disable or similar.

Updated. The new command "wifi 11k [enable/disable]" can be used to enable or disable 11k, instead of giving paramter 0/1.

jukkar · 2024-09-25T07:02:21Z

subsys/net/l2/wifi/wifi_shell.c

+		}
+		(void)memcpy((void *)params.ssid, (const void *)argv[2],
+			     (size_t)strlen(argv[2]));
+


Remove extra empty line

jukkar · 2024-09-25T07:02:37Z

subsys/net/l2/wifi/wifi_shell.c

+	if (argc == 3)
+		PR("%s %s %s requested\n", argv[0], argv[1], argv[2]);
+	else
+		PR("%s requested\n", argv[0]);


{} are missing

jukkar · 2024-09-25T07:03:59Z

modules/hostap/src/supp_api.c

-			if (!wpa_cli_cmd_v("set_network %d key_mgmt WPA-PSK",
-					   resp.network_id)) {
+			if (!wpa_cli_cmd_v("set_network %d key_mgmt WPA-PSK%s",
+			    resp.network_id, params->ft_used ? " FT-PSK" : "")) {


jukkar · 2024-09-25T07:05:52Z

modules/hostap/Kconfig

@@ -249,6 +249,9 @@ if WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE
 		default 16384
 endif

+config WIFI_NM_WPA_SUPPLICANT_ROAMING
+	bool "Roaming support"


Could there be a help text also describing the supported roaming functionality

Added help text.

jukkar · 2024-09-25T07:07:03Z

modules/hostap/src/supp_api.c

@@ -75,6 +75,8 @@ static void supp_shell_connect_status(struct k_work *work);
 static K_WORK_DELAYABLE_DEFINE(wpa_supp_status_work,
 		supp_shell_connect_status);

+#define STR_CUR_TO_END(cur) (cur) = (&(cur)[0] + strlen((cur)))


This causes the length to be calculated multiple times when this is called, why not have a len parameter in this macro and calculate the value only once.

This macro define is not created in this PR. I just moved it to this location. This macro define was created and used for DPP feature.

jukkar · 2024-09-25T07:09:00Z

modules/hostap/src/supp_api.c

+	char cmd[100] = {0};
+	char *pos = cmd;
+	char *end = pos + 100;


Could you have a define for the array length, or alternatively use sizeof. It is error prone to hard code the value as they can become mismatched if changed later.
So we could say here char *end = pos + sizeof(cmd);

Updated. Added new macro define for the array length.

jukkar · 2024-09-25T07:11:29Z

samples/net/wifi/boards/rd_rw612_bga.conf

@@ -73,6 +73,8 @@ CONFIG_ZPERF_WORK_Q_THREAD_PRIORITY=3
 CONFIG_NET_SOCKETS_SERVICE_THREAD_PRIO=3


In commit subsys: net: Increase net_mgmt task priority, please remove the subsys: prefix as that is not needed to mention.

Removed subsys: in commit message.

Add 11k cmds support. User can issue 11k cmds to enable/disable 11k and send Neighbor Report Request packet. Signed-off-by: Hui Bai <hui.bai@nxp.com>

Add 80211R support in hostap. Add cmd wifi connect option '-R' to enable 80211R. Signed-off-by: Hui Bai <hui.bai@nxp.com>

Added new ops and events in glue layer to support roaming. Added new flag WIFI_NM_WPA_SUPPLICANT_ROAMING to control roaming feature. Signed-off-by: Hui Bai <hui.bai@nxp.com>

Originally, the net_mgmt task priority is very low. Based on roaming implementation, roaming is triggered in net_mgmt task. When running UDP test while doing roaming, the net_mgmt task won't have much chance to run and roaming can't be triggered. Increase it to 3, which is same value of supplicant task. Signed-off-by: Hui Bai <hui.bai@nxp.com>

Update hostap repo in west.yml Signed-off-by: Hui Bai <hui.bai@nxp.com>

zephyrbot added area: Networking area: Wi-Fi Wi-Fi platform: NXP Drivers NXP Semiconductors, drivers area: Samples Samples labels Sep 19, 2024

zephyrbot requested review from danieldegrasse, dbaluta, decsny, dleach02, jukkar, kartben, Kludentwo, krish2718, manuargue, MarkWangChinese, mmahadevan108, pdgendt, rlubos, ssharks and tbursztyka September 19, 2024 06:32

zephyrbot assigned krish2718 and jukkar Sep 19, 2024

zephyrbot added manifest manifest-hostap DNM This PR should not be merged (Do Not Merge) labels Sep 19, 2024

decsny removed their request for review September 20, 2024 16:58

jukkar reviewed Sep 25, 2024

View reviewed changes

nxf58150 force-pushed the roaming_support branch from 6bfcd76 to 4a76bbd Compare September 26, 2024 05:30

zephyrbot requested a review from nashif September 26, 2024 05:30

nxf58150 force-pushed the roaming_support branch 4 times, most recently from f9f47bd to e8bd2a4 Compare September 27, 2024 02:18

nxf58150 added 5 commits October 9, 2024 10:01

modules: hostap: add 11k cmd support

2e30fb3

Add 11k cmds support. User can issue 11k cmds to enable/disable 11k and send Neighbor Report Request packet. Signed-off-by: Hui Bai <hui.bai@nxp.com>

modules: hostap: add IEEE80211R support

2af6481

Add 80211R support in hostap. Add cmd wifi connect option '-R' to enable 80211R. Signed-off-by: Hui Bai <hui.bai@nxp.com>

modules: hostap: add 11k/v/r roaming support

57d74ee

Added new ops and events in glue layer to support roaming. Added new flag WIFI_NM_WPA_SUPPLICANT_ROAMING to control roaming feature. Signed-off-by: Hui Bai <hui.bai@nxp.com>

manifest: Update hostap repo

cc509bc

Update hostap repo in west.yml Signed-off-by: Hui Bai <hui.bai@nxp.com>

nxf58150 force-pushed the roaming_support branch from e8bd2a4 to cc509bc Compare October 9, 2024 02:32

nxf58150 requested a review from jukkar October 9, 2024 05:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modules: hostap: 11k/v/r roaming support #78684

modules: hostap: 11k/v/r roaming support #78684

nxf58150 commented Sep 19, 2024

zephyrbot commented Sep 19, 2024 •

edited

Loading

nxf58150 commented Sep 24, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024 •

edited

Loading

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024 •

edited

Loading

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

jukkar Sep 25, 2024

nxf58150 Sep 26, 2024

		if (params && strlen(params->ssid)) {
		if (strlen(params->ssid) > WIFI_SSID_MAX_LEN) {

		@@ -73,6 +73,8 @@ CONFIG_ZPERF_WORK_Q_THREAD_PRIORITY=3
		CONFIG_NET_SOCKETS_SERVICE_THREAD_PRIO=3

modules: hostap: 11k/v/r roaming support #78684

Are you sure you want to change the base?

modules: hostap: 11k/v/r roaming support #78684

Conversation

nxf58150 commented Sep 19, 2024

zephyrbot commented Sep 19, 2024 • edited Loading

nxf58150 commented Sep 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nxf58150 Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nxf58150 Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zephyrbot commented Sep 19, 2024 •

edited

Loading

nxf58150 Sep 26, 2024 •

edited

Loading

nxf58150 Sep 26, 2024 •

edited

Loading