bugfix: esp32s3: allows QIO and QOUT flash modes #79286
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
a756e4f
to
58f37e6
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
58f37e6
to
43151dc
Compare
wmrsouza
changed the title
zephyrbot
requested review from
LucasTambor,
marekmatej,
raffarost,
sylvioalves and
uLipe
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
43151dc
to
d8822a6
Compare
sylvioalves
reviewed
Oct 8, 2024
soc/espressif/esp32s3/default.ld
Outdated
| @@ -436,6 +436,10 @@ SECTIONS | |||
| *libzephyr.a:bootloader_console.*(.literal .text .literal.* .text.*) | |||
| *libzephyr.a:bootloader_panic.*(.literal .text .literal.* .text.*) | |||
|
|
|||
| #if defined(CONFIG_ESPTOOLPY_FLASHMODE_QIO) || defined(CONFIG_ESPTOOLPY_FLASHMODE_QOUT) | |||
There was a problem hiding this comment.
I think you can dismiss this conditions in both cases.
Update hal to cover latest features and fixes. Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
Allows QIO and QOUT flash modes to work on esp32s3 Fixes zephyrproject-rtos#73677 Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
wmrsouza
force-pushed
the
bugfix/QIO_mode
branch
from
d8822a6
to
16b1ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows QIO and QOUT flash modes to work on esp32s3
Fixes #73677