Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: input: ili2132a: add support for ili2132a touch controller #79310

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Jaldemark
Copy link
Contributor

This commit adds basic ili2132a touch controller driver, supporting one finger.

@zephyrbot zephyrbot added the area: Input Input Subsystem and Drivers label Oct 2, 2024
drivers/input/Kconfig.ili2132a Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
dts/bindings/input/ilitek,ili2132a.yaml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 2, 2024

Hello @Jaldemark, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@fabiobaltieri
Copy link
Member

also check for the compliance errors, note that you can run that locally with ./scripts/ci/check_compliance.py

Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff few more details

drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
dts/bindings/input/ilitek,ili2132a.yaml Outdated Show resolved Hide resolved
dts/bindings/input/ilitek,ili2132a.yaml Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Show resolved Hide resolved
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry actually one more comment, can you add an instance of this to tests/drivers/build_all/input/app.overlay so this gets built by CI?

@Jaldemark Jaldemark force-pushed the ili2132_driver branch 2 times, most recently from 48a7557 to 6282ed8 Compare October 9, 2024 06:19
dts/bindings/input/ilitek,ili2132a.yaml Outdated Show resolved Hide resolved
drivers/input/Kconfig.ili2132a Outdated Show resolved Hide resolved
drivers/input/input_ili2132a.c Outdated Show resolved Hide resolved
This commit adds basic ili2132a touch controller driver.

Signed-off-by: Joel Jaldemark <joeljaldemark@outlook.com>
@aescolar aescolar merged commit 2a1fde7 into zephyrproject-rtos:main Oct 9, 2024
23 checks passed
Copy link

github-actions bot commented Oct 9, 2024

Hi @Jaldemark!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Input Input Subsystem and Drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants