shell: add generic RX buffer flush function #79371
Merged
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
from
ab9d738
to
8a9c440
Compare
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
from
8a9c440
to
882fe44
Compare
pdgendt
reviewed
Oct 3, 2024
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
2 times, most recently
from
e0b64f2
to
fad60f3
Compare
henrikbrixandersen
previously approved these changes
Oct 7, 2024
|
@nordic-krch kind reminder |
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
from
fad60f3
to
982a06e
Compare
pdgendt
reviewed
Oct 8, 2024
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
from
982a06e
to
2ade93e
Compare
pdgendt
reviewed
Oct 9, 2024
|
Commit now has flushing function but it is not called anywhere and commit message states that it is called during resume. |
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
from
2ade93e
to
e27563c
Compare
I don’t recall any backend flush function; there was only a function to flush the shell's TX buffer. |
Added a generic function `z_shell_backend_rx_buffer_flush` to clear the RX buffer when resuming the shell. The function repeatedly calls the backend's `read` API until the buffer is empty or a maximum of 1000 iterations is reached. This prevents unintended command execution after `shell_start`. Signed-off-by: Jakub Rzeszutko <jakub.rzeszutko@verkada.com>
jakub-uC
force-pushed
the
feature/shell-add-flush-function-to-shell-api
branch
from
e27563c
to
993b8bb
Compare
nordic-krch
approved these changes
Oct 9, 2024
pdgendt
approved these changes
Oct 9, 2024
jakub-uC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a generic function
z_shell_backend_rx_buffer_flushto clear the RX buffer when resuming the shell. The function repeatedly calls the backend'sreadAPI until the buffer is empty or a maximum of 1000 iterations is reached. This prevents unintended command execution aftershell_start.