net: socket_service: remove work_q parameter
#79446
Merged
+23
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
Release Notes
zephyrbot
requested review from
carlescufi,
dkalowsk,
jakub-uC,
jukkar,
kartben,
maass-hamburg,
mmahadevan108,
nashif,
pdgendt,
rlubos,
ssharks and
tbursztyka
JordanYates
force-pushed
the
241005_socket_services_workq
branch
from
c1cb1d7
to
5a00603
Compare
jukkar
previously approved these changes
Oct 5, 2024
bjarki-andreasen
previously approved these changes
Oct 5, 2024
maass-hamburg
previously approved these changes
Oct 5, 2024
rlubos
previously approved these changes
Oct 8, 2024
aescolar
reviewed
Oct 9, 2024
doc/releases/migration-guide-4.0.rst
Outdated
| @@ -316,6 +316,9 @@ Networking | |||
| from :zephyr_file:`include/zephyr/net/buf.h` to :zephyr_file:`include/zephyr/net_buf.h` and the | |||
| implementation moved to :zephyr_file:`lib/net_buf/`. (:github:`78009`) | |||
|
|
|||
| * The ``work_q`` parameter to ``NET_SOCKET_SERVICE_SYNC_DEFINE`` and | |||
| ``NET_SOCKET_SERVICE_SYNC_DEFINE_STATIC`` has been removed as it was always ignored. | |||
There was a problem hiding this comment.
Please add a link to this PR (:github:`79446`)
Remove the `work_q` parameter from `NET_SOCKET_SERVICE_SYNC_DEFINE` and `NET_SOCKET_SERVICE_SYNC_DEFINE_STATIC` as this feature was dropped during review but the removal was not 100% complete. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
dismissed stale reviews from rlubos, maass-hamburg, bjarki-andreasen, and jukkar
via
994c708
JordanYates
force-pushed
the
241005_socket_services_workq
branch
from
5a00603
to
994c708
Compare
aescolar
approved these changes
Oct 9, 2024
maass-hamburg
approved these changes
Oct 9, 2024
rlubos
approved these changes
Oct 9, 2024
bjarki-andreasen
approved these changes
Oct 9, 2024
jukkar
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
work_qparameter fromNET_SOCKET_SERVICE_SYNC_DEFINEandNET_SOCKET_SERVICE_SYNC_DEFINE_STATICas this feature was dropped during review but the removal was not 100% complete.Original PR #66758