boards: PHYTEC: remove SoC prefix from board name #79575
+37
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnltz
reviewed
Oct 8, 2024
For easier recognition PHYTEC boards have been prefixed with the SoC name. As the new hardware model includes the SoC and cpu, this prefixing is not needed anymore. All PHYTEC eval boards have an individual and unique name and can be found easily via this name. Signed-off-by: Jonas Remmert <j.remmert@phytec.de>
For easier recognition PHYTEC boards have been prefixed with the SoC name. As the new hardware model includes the SoC and cpu, this prefixing is not needed anymore. All PHYTEC eval boards have an individual and unique name and can be found easily via this name. Signed-off-by: Jonas Remmert <j.remmert@phytec.de>
jonas-rem
force-pushed
the
WIP/j.remmert@phytec.de/phyboard_prefix_cleanup
branch
from
daf8ecf
to
34d2769
Compare
nordicjm
requested changes
Oct 9, 2024
|
@jonas-rem Here is a reference for zephyr/boards/deprecated.cmake Line 49 in 9f60075 |
kartben
requested changes
Oct 9, 2024
There was a problem hiding this comment.
A welcome but breaking change so please mention it in the migration guide.
Also add redirect entries in doc/scripts/_redirects.py
Edit: possibly non breaking as others mentioned by using deprecated board name. Still needs a mention in the release notes to give people a heads-up though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier recognition, PHYTEC boards have been prefixed with the SoC name. As the new hardware model includes the SoC and cpu, prefixing is not needed anymore. All PHYTEC eval boards have an individual and unique name and can be found easily via this name.