Bluetooth: Add a validation for le_conn_update_complete() and bt_hci_le_subrate_change_event() #79584
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
sjanc,
Thalley and
theob-pro
Thalley
requested changes
Oct 9, 2024
|
Should this code be behind some Kconfig symbol to avoid increasing binary size? A controller should never give values that are out of spec |
It's a good question. We have many (hopefully most) where we have some checks against what we receive from the controller. Should we trust everything from the controller? It's arguably weird that we only check a subset of data from the controller |
swkim101
force-pushed
the
main
branch
2 times, most recently
from
29a7722
to
60ca2cf
Compare
Like 2ca179c, check and warn if incoming HCI event parameters exceed the specification. This helps debugging controllers by detecting the out-of-spec value that shouldn't appear. Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
Thalley
reviewed
Oct 9, 2024
| LOG_WRN("peripheral_latency exceeds the valid range 0x%04x", | ||
| conn->le.latency); | ||
| } | ||
| if (BT_HCI_LE_CONTINUATION_NUM_MAX < conn->le.subrate.continuation_number) { |
There was a problem hiding this comment.
Why is this not
Suggested change
| if (BT_HCI_LE_CONTINUATION_NUM_MAX < conn->le.subrate.continuation_number) { | |
| if (conn->le.subrate.continuation_number > BT_HCI_LE_CONTINUATION_NUM_MAX) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like 2ca179c, check and warn if incoming HCI event parameters exceed the specification to help debugging.
Although this does not strictly comply with the specification, I don't see any misuse (like div-by-zero).
So, adding warnings seems enough at this point.