Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: Controller: Fix minimum offset for subsequent CISes #81823

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Bluetooth: Controller: Fix minimum offset for subsequent CISes #81823

merged 1 commit into from
Nov 27, 2024

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Nov 24, 2024 •
edited
Loading

Fix CIS offset calculation by Central for subsequent CISes such that when compensating for dissimilar ACL and ISO intervals, ensure that minimum offset does not cause a collision between the ACL and the CIS event at the instant.

Fixes commit 3b3d53f ("Bluetooth: Controller: Fix CIS offset_min for dissimilar interval").

Relates to the following assertion in #81093:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/11981634118/job/33408239195?pr=81093#step:13:17049

d_01: @00:00:24.895630  ASSERTION FAIL [cig_offset_us > 0] @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn_iso.c:1020
d_01: @00:00:24.895630  @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn_iso.c:1020
d_01: @00:00:24.895630  [00:00:24.895,629] <err> os: z_fatal_error: >>> ZEPHYR FATAL ERROR 3: Kernel oops on CPU 0
d_01: @00:00:24.895630  [00:00:24.895,629] <err> os: z_fatal_error: Current thread: 0x855f180 (idle)
d_01: @00:00:24.895630  [00:00:24.895,629] <err> os: k_sys_fatal_error_handler: Halting system

@cvinayak
Bluetooth: Controller: Fix minimum offset for subsequent CISes
fa8d793 
Fix CIS offset calculation by Central for subsequent CISes
such that when compensating for dissimilar ACL and ISO
intervals, ensure that minimum offset does not cause a
collision between the ACL and the CIS event at the instant.

Fixes commit 3b3d53f ("Bluetooth: Controller: Fix CIS
offset_min for dissimilar interval").

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak marked this pull request as ready for review November 25, 2024 03:57
@cvinayak cvinayak mentioned this pull request Nov 25, 2024
Open
@kruithofa kruithofa removed their request for review November 27, 2024 07:01
@kartben kartben merged commit 478cace into zephyrproject-rtos:main Nov 27, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aescolar aescolar aescolar approved these changes

@carlescufi carlescufi carlescufi approved these changes

@Thalley Thalley Thalley approved these changes

@erbr-ot erbr-ot Awaiting requested review from erbr-ot

@mtpr-ot mtpr-ot Awaiting requested review from mtpr-ot

@thoh-ot thoh-ot Awaiting requested review from thoh-ot

@wopu-ot wopu-ot Awaiting requested review from wopu-ot

Assignees

@cvinayak cvinayak

Labels
area: Bluetooth Controller area: Bluetooth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cvinayak @Thalley @carlescufi @aescolar @kartben @zephyrbot