modules: hal_tdk: Introduce kconfig symbol to prevent cmake warning #83151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_tdk
DNM
pdgendt
force-pushed
the
hal-tdk-symbols
branch
from
c5e69cc to
a7875f1
Compare
The CONFIG_ZEPHYR_HAL_TDK_MODULE is always set if the module is on disk, introduce an implied symbol to prevent a cmake warning if no TDK drivers are needed. Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
pdgendt
force-pushed
the
hal-tdk-symbols
branch
from
a7875f1 to
0b83e6b
Compare
|
Thanks a lot @pdgendt for fixing this issue! |
|
How to move forward as there are no reviewers? Do you have any clues @pdgendt ? |
henrikbrixandersen
approved these changes
Dec 19, 2024
kartben
approved these changes
Dec 19, 2024
kartben
added
the
Hotfix
|
flagging as "lukewarm-fix" to get this merged a bit sooner. If anyone disagrees with the approach please let me know :) |
fabiobaltieri
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CONFIG_ZEPHYR_HAL_TDK_MODULEis always set if the module is on disk, introduce an implied symbol to prevent a cmake warning if no TDK drivers are needed.