toolchain: Add macros to disable compiler warnings #84063
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thughes
force-pushed
the
add-toolchain-compiler-warning-macros
branch
from
088434f to
3949f4e
Compare
This was referenced Jan 17, 2025
|
See comment here: #84065 (review) |
tejlmand
reviewed
Jan 22, 2025
These macros allow disabling compiler warnings for all compilers or only gcc or only clang. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
add-toolchain-compiler-warning-macros
branch
from
3949f4e to
a2a59f9
Compare
|
@tejlmand I think I addressed your comments, so let me know if there's anything else. |
RobinKastberg
approved these changes
Jan 29, 2025
tejlmand
approved these changes
Jan 30, 2025
tejlmand
requested changes
Jan 30, 2025
thughes
force-pushed
the
add-toolchain-compiler-warning-macros
branch
from
a2a59f9 to
9cfce6b
Compare
tejlmand
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros allow disabling compiler warnings for all compilers or only gcc or only clang.
Note that the reason to have gcc and clang-specific versions in addition to the general version is that sometimes only clang or gcc will emit a warning.
A followup PR will convert existing code to use these: #84065