Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vue import #12

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix: vue import #12

merged 1 commit into from
Feb 2, 2023

Conversation

Luk-z
Copy link
Contributor

@Luk-z Luk-z commented Jan 13, 2023

Description

This pr resolves these issues storybook-zeplin and fixes #11.

Solution

Just import vue with import Vue from "vue"; instead of import Vue from "vue/dist/vue";.

I've tested this solution on react+storybook project with pnpmusing this patched version of the package https://github.com/Luk-z/storybook-inspector/tree/v0.1.3-patch.2 and it works

@yuqu
Copy link
Contributor

yuqu commented Jan 13, 2023

Thanks for opening this PR.

I remember that there was a specific reason to keep the import that way. Let us to investigate if any problems occur, otherwise it is good to go with this PR.

I'm having hard time to reproduce the reported issue, if possible, could you share a small example? I have a couple of ideas to lazy-load vue library. If the changes in the PR is going to cause any issue as I mentioned above, I'll need to reproduce it to investigate alternative solutions.

@Luk-z
Copy link
Contributor Author

Luk-z commented Jan 16, 2023

Hi @yuqu,

i got the problem using storybook v7. These are 2 repo using pnpm and npm. Both have this problem. I wrote some infos in readme.
With storybook v6 and npm it works.

@yuqu yuqu changed the title 🐛 #11 fix vue import fix: vue import Feb 2, 2023
@yuqu yuqu merged commit 62824df into zeplin:main Feb 2, 2023
yuqu added a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue should not be imported in react projects
2 participants