Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-newimg-readme #54

Merged
merged 1 commit into from
Oct 20, 2022
Merged

add-newimg-readme #54

merged 1 commit into from
Oct 20, 2022

Conversation

lemostrash
Copy link
Contributor

  • I changed the cover image.
  • If you want i can help you with the cover photos :)

I made very simple changes, but that make a big difference

@zer0Kerbal zer0Kerbal added issue: image deals with images and imgbot state: approved Approved to proceed. hacktoberfest flag for entry into hacktoberfest labels Oct 20, 2022
@zer0Kerbal zer0Kerbal changed the base branch from master to 1.1.2.1-release October 20, 2022 01:11
@zer0Kerbal
Copy link
Owner

  • I changed the cover image.
  • If you want i can help you with the cover photos :)

I made very simple changes, but that make a big difference

I like.

The whole hero-image started because CurseForge requires a > 400x400px image for each listing. Just have been reusing it for, well, you see.

So yes, please do with all the other addons I have, some don't even have the CurseForge image (or a very bad one) yet.

I will update the GH Social preview to this glorious image.

Thank you

@zer0Kerbal zer0Kerbal added this to the 1.1.2.1-release milestone Oct 20, 2022
@zer0Kerbal zer0Kerbal added type: enhancement Requested functionality, features, pages, workflows, endpoints, etc. hacktoberfest-accepted flag for stating PR is accepted as appropriate for hacktoberfest and removed hacktoberfest flag for entry into hacktoberfest labels Oct 20, 2022
@zer0Kerbal zer0Kerbal merged commit a8cd2db into zer0Kerbal:1.1.2.1-release Oct 20, 2022
@zer0Kerbal
Copy link
Owner

postscript as you can see here the cover photo auto-propagates to other places it is used.

@lemostrash
Copy link
Contributor Author

I was going to create a thumbnail for the video, but I didn't have a good quality image of the game, I can help u with a repackage for the repository images if u want.

@zer0Kerbal
Copy link
Owner

https://github.com/zer0Kerbal/Halloween

@zer0Kerbal zer0Kerbal linked an issue Oct 29, 2022 that may be closed by this pull request
Update Hero Logo #58
Closed
1 task
@zer0Kerbal zer0Kerbal mentioned this pull request Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zer0Kerbal zer0Kerbal zer0Kerbal approved these changes

Assignees

@zer0Kerbal zer0Kerbal

@lemostrash lemostrash

Labels
hacktoberfest-accepted flag for stating PR is accepted as appropriate for hacktoberfest issue: image deals with images and imgbot state: approved Approved to proceed. type: enhancement Requested functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
1.1.2.1-release
Development

Successfully merging this pull request may close these issues.

Update Hero Logo
2 participants
@lemostrash @zer0Kerbal