Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't depend on home_server field in registration response #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Don't depend on home_server field in registration response #105

wants to merge 1 commit into from

Conversation

timmc
Copy link
Contributor

@timmc timmc commented Mar 5, 2023

This field is deprecated in the client-server API and has been removed from Dendrite, causing the UI to error when handling a registration response.

Reference: https://spec.matrix.org/v1.6/client-server-api/#post_matrixclientv3register

It appears that the home_server field wasn't actually being used here anyhow, so just remove the line that tries to fetch it. The spec indicates that if it is needed, the caller should instead split the user_id at the first colon.

Fixes #103

@timmc
fix: Don't depend on home_server field in registration response
41da9a9 
This field is deprecated in the client-server API and has been removed from
Dendrite, causing the UI to error when handling a registration response.

Reference: https://spec.matrix.org/v1.6/client-server-api/#post_matrixclientv3register

It appears that the `home_server` field wasn't actually being used here
anyhow, so just remove the line that tries to fetch it. The spec indicates
that if it is needed, the caller should instead split the user_id at the
first colon.

Fixes zeratax#103
@timmc timmc mentioned this pull request Mar 5, 2023
Open
@timmc
Copy link
Contributor Author

timmc commented Mar 5, 2023

  • I'm not sure why the tests are failing. I get the same failure locally even without my changes.
  • There's another unused field access_token here. May be worth removing as well, since it's unused?
  • There are also references to home_server and access_token in tests/test_registration.py. I wasn't entirely sure what to do with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

home_server field in registration response is deprecated
1 participant
@timmc