MacOS issues reported in #455 #456
Conversation
mmd-osm
force-pushed
the
patch/issue_455_part1
branch
from
e6952dc
to
d2aad61
Compare
|
I cloned the repository from this branch: everything compiled without errors! |
|
Ok, great. I think what’s left now is to add unit tests for macOS… |
mmd-osm
force-pushed
the
patch/issue_455_part1
branch
4 times, most recently
from
adbcf2c
to
9907304
Compare
|
I don't know if you've already figured out what the problem is with the test "Tag: Value with max 255 unicode characters, <= 255" The behavior of mbsrtowcs is somehow different for Linux and macOS for the same 64-character string 😎 Linux (Docker) vs macOS (note the len value when s.size() is equal)
|
mmd-osm
force-pushed
the
patch/issue_455_part1
branch
from
612739f
to
607115f
Compare
Fall back to previous implementation 1a17261 in this case.
mmd-osm
force-pushed
the
patch/issue_455_part1
branch
from
9296e25
to
a62ab3f
Compare
|
No idea really why mbsrtowcs isn't working as expected. I've added another one-liner implementation for macOS now. Some deprecation warnings have been silenced, which is ok for now. pg_virtualenv tests on a real database instance are currently disabled, since that tool seems to be unavailable on macOS. Maybe this could be addressed in another PR. |
|
By the way, thanks for the GH action file. I've cherry picked your commit, so that you're officially listed as contributor for this repo now. |
Fixes #455