Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow for unittesting is not working correctly #6

Open
zerex290 opened this issue May 31, 2023 · 0 comments
Open

GitHub workflow for unittesting is not working correctly #6

zerex290 opened this issue May 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@zerex290
Copy link
Owner

At the moment asynchronous unittests in workflow are always passed, even if they shouldn't (because of possible bugs). The reason of pass of all asynchronous tests is skipping tests by pystest with such warnings. These warnings means that pytest doesn't try to await created coroutine test objects.

Using plugins (suggested by pytest) at requirements-test.txt (trio, twisted etc) doesn't really await async functions because of default asyncio_mode=STRICT configuration which involves decorating asynchronous test functions with @pytest.mark.asyncio.

Such unwanted behaviour can be fixed by using pytest-asyncio plugin for pytest and setting asyncio_mode=auto at pytest.ini file.

These steps can allow to perform testing correctly (and it has been successfully checked locally), but new problem occurs at github actions workflow: Tests requiring authorization fail with SankakuServerError and status code 500. And the oddity is that not all mentioned test fail.

@zerex290 zerex290 added the bug Something isn't working label May 31, 2023
zerex290 added a commit that referenced this issue Aug 5, 2023
According to issue #6 at the moment CI at gh workflows doesn't run tests
correctly, so it need to be somehow fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant